makes create_detector generic

Author: brandon

src/groundlight/client.py

@@ -15,19 +15,19 @@
 from groundlight_openapi_client.api.user_api import UserApi
 from groundlight_openapi_client.exceptions import NotFoundException, UnauthorizedException
 from groundlight_openapi_client.model.b_box_geometry_request import BBoxGeometryRequest
+from groundlight_openapi_client.model.count_mode_configuration import CountModeConfiguration
 from groundlight_openapi_client.model.detector_creation_input_request import DetectorCreationInputRequest
 from groundlight_openapi_client.model.label_value_request import LabelValueRequest
+from groundlight_openapi_client.model.multi_class_mode_configuration import MultiClassModeConfiguration
 from groundlight_openapi_client.model.patched_detector_request import PatchedDetectorRequest
 from groundlight_openapi_client.model.roi_request import ROIRequest
 from model import (
     ROI,
     BinaryClassificationResult,
-    CountModeConfiguration,
     Detector,
     DetectorGroup,
     ImageQuery,
     ModeEnum,
-    MultiClassModeConfiguration,
     PaginatedDetectorList,
     PaginatedImageQueryList,
 )
@@ -1524,7 +1524,7 @@ def create_counting_detector(  # noqa: PLR0913 # pylint: disable=too-many-argume
         if max_count is None:
             mode_config = CountModeConfiguration(class_name=class_name)
         else:
-            mode_config = CountModeConfiguration(max_count=max_count, class_name=class_name)
+            mode_config = CountModeConfiguration(class_name=class_name, max_count=max_count)
 
         detector_creation_input.mode_configuration = mode_config
         obj = self.detectors_api.create_detector(detector_creation_input, _request_timeout=DEFAULT_REQUEST_TIMEOUT)

test/integration/test_groundlight.py

@@ -89,8 +89,10 @@ def test_create_detector(gl: Groundlight):
     ), "We expected the default confidence threshold to be used."
 
     # Test creating dectors with other modes
+    name = f"Test {datetime.utcnow()}"  # Need a unique name
     count_detector = gl.create_detector(name=name, query=query, mode=ModeEnum.COUNT, class_names="dog")
     assert str(count_detector)
+    name = f"Test {datetime.utcnow()}"  # Need a unique name
     multiclass_detector = gl.create_detector(name=name, query=query, mode=ModeEnum.MULTI_CLASS, class_names=["dog", "cat"])
     assert str(multiclass_detector)
 
@@ -790,13 +792,13 @@ def test_submit_image_query_with_empty_inspection_id(gl: Groundlight, detector:
 
 def test_binary_detector(gl: Groundlight):
     """
-    verify that we can create and submit to a counting detector
+    verify that we can create and submit to a binary detector
     """
     name = f"Test {datetime.utcnow()}"
     created_detector = gl.create_binary_detector(name, "Is there a dog", "dog", confidence_threshold=0.0)
     assert created_detector is not None
-    count_iq = gl.submit_image_query(created_detector, "test/assets/dog.jpeg")
-    assert count_iq.result.label is not None
+    binary_iq = gl.submit_image_query(created_detector, "test/assets/dog.jpeg")
+    assert binary_iq.result.label is not None
 
 def test_counting_detector(gl: Groundlight):
     """