fix(ENGKNOW-3055): Fix replace on no matching columns. (#98)

Author: gmagnu

gortools/src/main/scala/gorsat/Analysis/ReplaceAnalysis.scala

@@ -72,18 +72,20 @@ case class ReplaceAnalysis(context: GorContext, executeNor: Boolean, paramString
   }
 
   override def process(r: Row): Unit = {
-    val cvp = ReplaceCvp(r)
-    try {
-       val columnValues = columnsToReplace.indices.map(i => {
-         cvp.replaceCol = columnsToReplace(i)
-         val exIx = if(i > expressions.length - 1) 0 else i
-         evalFunction(cvp, expressions(exIx), expressionTypes(exIx))
-       })
-      r.setColumns(columnsToReplace, columnValues.toArray)
-    } catch {
-      case e: GorParsingException =>
-        val msg = s"Error in step: REPLACE $paramString\n${e.getMessage}"
-        throw new GorDataException(msg, -1, header, r.getAllCols.toString, e)
+    if (!columnsToReplace.isEmpty) {
+      val cvp = ReplaceCvp(r)
+      try {
+        val columnValues = columnsToReplace.indices.map(i => {
+          cvp.replaceCol = columnsToReplace(i)
+          val exIx = if (i > expressions.length - 1) 0 else i
+          evalFunction(cvp, expressions(exIx), expressionTypes(exIx))
+        })
+        r.setColumns(columnsToReplace, columnValues.toArray)
+      } catch {
+        case e: GorParsingException =>
+          val msg = s"Error in step: REPLACE $paramString\n${e.getMessage}"
+          throw new GorDataException(msg, -1, header, r.getAllCols.toString, e)
+      }
     }
     super.process(r)
   }

gortools/src/main/scala/gorsat/Commands/Replace.scala

@@ -38,7 +38,7 @@ class Replace extends CommandInfo("REPLACE",
     val colNums = columnsFromHeader(colName, forcedInputHeader, executeNor).toArray
 
     val filteredColNums = colNums.filter(i => i>= 2)
-    if(filteredColNums.isEmpty) {
+    if(!colNums.isEmpty && filteredColNums.isEmpty) {
       throw new GorParsingException("REPLACE is not allowed on Chrom/Pos columns")
     }
     CommandParsingResult(ReplaceAnalysis(context, executeNor, formula, forcedInputHeader, filteredColNums), forcedInputHeader)

gortools/src/test/java/gorsat/UTestReplace.java

@@ -97,4 +97,13 @@ public void replaceStarWhenUsingNor() {
                 "chrN\t0\t42\t42\t42\t42\n";
         Assert.assertEquals(expected, res);
     }
+
+    @Test
+    public void replaceNoExistingColumns() {
+        String query = "gorrow chr1,1 " +
+                "| replace Foo_* if(#rc='0','wt',#rc)";
+        String result = TestUtils.runGorPipe(query);
+        Assert.assertEquals("chrom\tpos\nchr1\t1\n", result);
+    }
+
 }