-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
priority: p0Highest priority. Critical issue. P0 implies highest priority.Highest priority. Critical issue. P0 implies highest priority.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
After upgrading react-native-navigation-sdk from v0.9.3 to v0.11.0 (the private-header change was introduced in v0.10.1), iOS builds for projects that use both react-native-driver-sdk and react-native-navigation-sdk fail with:
fatal error: 'react-native-navigation-sdk/NavModule.h' file not found
This is because the navigation SDK's podspec started marking all headers private for encapsulation, and react-native-driver-sdk both (a) doesn't declare an explicit react-native-navigation-sdk CocoaPods dependency and (b) imports NavModule.h using framework-style import that isn't resolved under CocoaPods + use_frameworks! (static linkage) configuration.
Problem
Two issues need to be fixed in this repository's iOS sources:
- Missing dependency declaration in
react-native-driver-sdk.podspec:
s.dependency "React-Core"
s.dependency "GoogleRidesharingDriver", ">= 10.0.0", "< 10.1.0"
# Missing: s.dependency "react-native-navigation-sdk"
- Import syntax in
RCTDeliveryModule.mandRCTRideSharingModule.m:
Currently:#import <react-native-navigation-sdk/NavModule.h>
Proposed:#import "NavModule.h"
Environment details
- react-native-driver-sdk: 0.3.2
- react-native-navigation-sdk: 0.11.0
- CocoaPods: 1.16.2
- iOS: 26.0 and 26.1
Steps to reproduce
- Install both SDKs in a React Native app with CocoaPods (use
use_frameworks! :linkage => :static). - Run
pod install - Build the iOS app and observe the error:
Notes
- The root cause was that the navigation SDK started marking all headers private for encapsulation in v0.10.1
NavModule.handINavigationCallback.hneed to be public
[Bug]: [iOS] All headers marked as private breaking compatibility with react-native-driver-sdk react-native-navigation-sdk#503
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p0Highest priority. Critical issue. P0 implies highest priority.Highest priority. Critical issue. P0 implies highest priority.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.