Skip to content

Commit d73b4bb

Browse files
push fillna into op
1 parent b73b649 commit d73b4bb

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

bigframes/core/compile/ibis_compiler/scalar_op_registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1062,7 +1062,7 @@ def isin_op_impl(x: ibis_types.Value, op: ops.IsInOp):
10621062
if op.match_nulls and contains_nulls:
10631063
return x.isnull() | x.isin(matchable_ibis_values)
10641064
else:
1065-
return x.isin(matchable_ibis_values)
1065+
return x.isin(matchable_ibis_values).fillna(False)
10661066

10671067

10681068
@scalar_op_compiler.register_unary_op(ops.ToDatetimeOp, pass_op=True)

bigframes/dataframe.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2755,11 +2755,11 @@ def isin(self, values) -> DataFrame:
27552755
False, label=label, dtype=pandas.BooleanDtype()
27562756
)
27572757
result_ids.append(result_id)
2758-
return DataFrame(block.select_columns(result_ids)).fillna(value=False)
2758+
return DataFrame(block.select_columns(result_ids))
27592759
elif utils.is_list_like(values):
27602760
return self._apply_unary_op(
27612761
ops.IsInOp(values=tuple(values), match_nulls=True)
2762-
).fillna(value=False)
2762+
)
27632763
else:
27642764
raise TypeError(
27652765
"only list-like objects are allowed to be passed to "

0 commit comments

Comments
 (0)