I will refactor get_configuration to use a dataclass.

google-labs-jules[bot] · google-labs-jules[bot] · commit 826a70c02ac5 · 2025-07-25T20:07:14.000Z
This change introduces a new `BenchmarkConfig` frozen dataclass to provide a more structured way of handling benchmark configurations.

The `get_configuration` function in `tests/benchmark/utils.py` will be updated to return an instance of this dataclass.

All call sites for `get_configuration` will be updated to use the new dataclass object.
diff --git a/tests/benchmark/read_gbq_colab/sort_output.py b/tests/benchmark/read_gbq_colab/sort_output.py
@@ -44,21 +44,15 @@ def sort_output(
 
 
 if __name__ == "__main__":
-    (
-        project_id,
-        dataset_id,
-        table_id,
-        session,
-        suffix,
-    ) = utils.get_configuration(include_table_id=True)
+    config = utils.get_configuration(include_table_id=True)
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
         sort_output,
         current_path,
-        suffix,
-        project_id=project_id,
-        dataset_id=dataset_id,
-        table_id=table_id,
-        session=session,
+        config.benchmark_suffix,
+        project_id=config.project_id,
+        dataset_id=config.dataset_id,
+        table_id=config.table_id,
+        session=config.session,
     )
diff --git a/tests/benchmark/tpch/q1.py b/tests/benchmark/tpch/q1.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q1 as vendored_tpch_q1
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q1.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q1.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q10.py b/tests/benchmark/tpch/q10.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q10 as vendored_tpch_q10
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q10.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q10.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q11.py b/tests/benchmark/tpch/q11.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q11 as vendored_tpch_q11
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q11.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q11.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q12.py b/tests/benchmark/tpch/q12.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q12 as vendored_tpch_q12
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q12.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q12.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q13.py b/tests/benchmark/tpch/q13.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q13 as vendored_tpch_q13
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q13.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q13.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q14.py b/tests/benchmark/tpch/q14.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q14 as vendored_tpch_q14
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q14.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q14.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q15.py b/tests/benchmark/tpch/q15.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q15 as vendored_tpch_q15
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q15.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q15.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q16.py b/tests/benchmark/tpch/q16.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q16 as vendored_tpch_q16
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q16.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q16.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q17.py b/tests/benchmark/tpch/q17.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q17 as vendored_tpch_q17
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q17.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q17.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q18.py b/tests/benchmark/tpch/q18.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q18 as vendored_tpch_q18
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q18.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q18.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q19.py b/tests/benchmark/tpch/q19.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q19 as vendored_tpch_q19
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q19.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q19.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q2.py b/tests/benchmark/tpch/q2.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q2 as vendored_tpch_q2
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q2.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q2.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q20.py b/tests/benchmark/tpch/q20.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q20 as vendored_tpch_q20
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q20.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q20.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q21.py b/tests/benchmark/tpch/q21.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q21 as vendored_tpch_q21
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q21.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q21.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q22.py b/tests/benchmark/tpch/q22.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q22 as vendored_tpch_q22
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q22.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q22.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q3.py b/tests/benchmark/tpch/q3.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q3 as vendored_tpch_q3
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q3.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q3.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q4.py b/tests/benchmark/tpch/q4.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q4 as vendored_tpch_q4
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q4.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q4.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q5.py b/tests/benchmark/tpch/q5.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q5 as vendored_tpch_q5
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q5.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q5.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q6.py b/tests/benchmark/tpch/q6.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q6 as vendored_tpch_q6
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q6.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q6.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q7.py b/tests/benchmark/tpch/q7.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q7 as vendored_tpch_q7
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q7.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q7.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q8.py b/tests/benchmark/tpch/q8.py
@@ -17,9 +17,14 @@
 import bigframes_vendored.tpch.queries.q8 as vendored_tpch_q8
 
 if __name__ == "__main__":
-    project_id, dataset_id, session, suffix = utils.get_configuration()
+    config = utils.get_configuration()
     current_path = pathlib.Path(__file__).absolute()
 
     utils.get_execution_time(
-        vendored_tpch_q8.q, current_path, suffix, project_id, dataset_id, session
+        vendored_tpch_q8.q,
+        current_path,
+        config.benchmark_suffix,
+        config.project_id,
+        config.dataset_id,
+        config.session,
     )
diff --git a/tests/benchmark/tpch/q9.py b/tests/benchmark/tpch/q9.py
