Building on Debian 8

[stuwilkins]

Hi... In building on Debian 8, it appears that explicit_bzero is not in this version. In compiling, it complains with the error:

gcc -std=gnu99  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra  -Wl,-z,relro -Wl,--as-needed -o cat_authproto logging.o helpers/authproto.o test/cat_authproto.o  -lXfixes -lpam -lXcomposite -lXext -lm -lXmuu -lX11
helpers/authproto.o: In function `ReadPacket':
/home/stuwilkins/xsecurelock/helpers/authproto.c:184: undefined reference to `explicit_bzero'

It appears that the uitl.c and util.h are missing from the cat_authproto_SOURCES in Makefile.am. adding these:

diff --git a/Makefile.am b/Makefile.am
index 2cad64c..4be0c23 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -210,7 +210,8 @@ noinst_PROGRAMS = cat_authproto nvidia_break_compositor get_compositor remap_all
 cat_authproto_SOURCES = \
        logging.c logging.h \
        helpers/authproto.c helpers/authproto.h \
-   test/cat_authproto.c
+ test/cat_authproto.c \
+ util.c util.h
 nvidia_break_compositor_SOURCES = \
        test/nvidia_break_compositor.c
 nvidia_break_compositor_CPPFLAGS = $(macros)

Fixes the building. Should I put in a PR for this fix or is there another issue?

[divVerent]

Just send a PR so the fix gets attributed to you. This does seem to be right.

…

On Mon, Oct 12, 2020 at 6:46 AM Stuart Wilkins ***@***.***> wrote: Hi... In building on Debian 8, it appears that explicit_bzero is not in this version. In compiling, it complains with the error: gcc -std=gnu99 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra -Wl,-z,relro -Wl,--as-needed -o cat_authproto logging.o helpers/authproto.o test/cat_authproto.o -lXfixes -lpam -lXcomposite -lXext -lm -lXmuu -lX11 helpers/authproto.o: In function `ReadPacket': /home/stuwilkins/xsecurelock/helpers/authproto.c:184: undefined reference to `explicit_bzero' It appears that the uitl.c and util.h are missing from the cat_authproto_SOURCES in Makefile.am. adding these: diff --git a/Makefile.am b/Makefile.am index 2cad64c..4be0c23 100644 --- a/Makefile.am +++ b/Makefile.am @@ -210,7 +210,8 @@ noinst_PROGRAMS = cat_authproto nvidia_break_compositor get_compositor remap_all cat_authproto_SOURCES = \ logging.c logging.h \ helpers/authproto.c helpers/authproto.h \ - test/cat_authproto.c + test/cat_authproto.c \ + util.c util.h nvidia_break_compositor_SOURCES = \ test/nvidia_break_compositor.c nvidia_break_compositor_CPPFLAGS = $(macros) Fixes the building. Should I put in a PR for this fix or is there another issue? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#115>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5NMFQVPYEJGDJ2TXBEHTSKMCCXANCNFSM4SM2M2DQ> .

[stuwilkins]

Thanks! Submitted as #116

Will now have to speak to employer about the agreement.