Skip to content

Commit df52168

Browse files
committed
feat: add new fields regarding NULL values
jira: CQ-1959 risk: low
1 parent e9f31a9 commit df52168

5 files changed

Lines changed: 265 additions & 213 deletions

File tree

packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/declarative_model/physical_model/column.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ class CatalogDeclarativeColumn(Base):
1616
is_primary_key: Optional[bool] = None
1717
referenced_table_id: Optional[str] = None
1818
referenced_table_column: Optional[str] = None
19+
is_nullable: Optional[bool] = None
20+
null_value: Optional[str] = None
1921

2022
@staticmethod
2123
def client_class() -> type[DeclarativeColumn]:

packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/logical_model/dataset/dataset.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ class CatalogDeclarativeAttribute(Base):
8282
tags: Optional[list[str]] = None
8383
is_hidden: Optional[bool] = None
8484
locale: Optional[str] = None
85+
is_nullable: Optional[bool] = None
86+
null_value: Optional[str] = None
8587

8688
@staticmethod
8789
def client_class() -> type[DeclarativeAttribute]:
@@ -97,6 +99,8 @@ class CatalogDeclarativeFact(Base):
9799
description: Optional[str] = None
98100
tags: Optional[list[str]] = None
99101
is_hidden: Optional[bool] = None
102+
is_nullable: Optional[bool] = None
103+
null_value: Optional[str] = None
100104

101105
@staticmethod
102106
def client_class() -> type[DeclarativeFact]:
@@ -121,6 +125,8 @@ class CatalogDeclarativeAggregatedFact(Base):
121125
source_column_data_type: Optional[str] = None
122126
description: Optional[str] = None
123127
tags: Optional[list[str]] = None
128+
is_nullable: Optional[bool] = None
129+
null_value: Optional[str] = None
124130

125131
@staticmethod
126132
def client_class() -> type[DeclarativeAggregatedFact]:
@@ -171,6 +177,8 @@ class CatalogDeclarativeLabel(Base):
171177
locale: Optional[str] = None
172178
translations: Optional[list[CatalogDeclarativeLabelTranslation]] = None
173179
geo_area_config: Optional[CatalogGeoAreaConfig] = None
180+
is_nullable: Optional[bool] = None
181+
null_value: Optional[str] = None
174182

175183
@staticmethod
176184
def client_class() -> type[DeclarativeLabel]:
@@ -203,6 +211,8 @@ class CatalogDeclarativeReference(Base):
203211
source_columns: Optional[list[str]] = None
204212
source_column_data_types: Optional[list[str]] = None
205213
sources: Optional[list[CatalogDeclarativeReferenceSource]] = None
214+
is_nullable: Optional[bool] = None
215+
null_value: Optional[str] = None
206216

207217
@staticmethod
208218
def client_class() -> type[DeclarativeReference]:

packages/gooddata-sdk/tests/catalog/fixtures/organization/layout_notification_channels.yaml

Lines changed: 40 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,25 @@ interactions:
2929
- PLACEHOLDER
3030
Expires:
3131
- '0'
32+
Featurepolicy:
33+
- geolocation 'none'; midi 'none'; notifications 'none'; push 'none'; sync-xhr
34+
'none'; microphone 'none'; camera 'none'; magnetometer 'none'; gyroscope
35+
'none'; speaker 'none'; vibrate 'none'; fullscreen 'none'; payment 'none';
3236
Pragma:
3337
- no-cache
3438
Referrer-Policy:
35-
- no-referrer
39+
- same-origin
3640
Vary:
3741
- Origin
3842
- Access-Control-Request-Method
3943
- Access-Control-Request-Headers
4044
X-Content-Type-Options:
4145
- nosniff
46+
X-Frame-Options:
47+
- SAMEORIGIN
4248
X-GDC-TRACE-ID: *id001
4349
X-Xss-Protection:
44-
- '0'
50+
- 1; mode=block
4551
body:
4652
string:
4753
notificationChannels: []
@@ -77,19 +83,25 @@ interactions:
7783
DATE: *id001
7884
Expires:
7985
- '0'
86+
Featurepolicy:
87+
- geolocation 'none'; midi 'none'; notifications 'none'; push 'none'; sync-xhr
88+
'none'; microphone 'none'; camera 'none'; magnetometer 'none'; gyroscope
89+
'none'; speaker 'none'; vibrate 'none'; fullscreen 'none'; payment 'none';
8090
Pragma:
8191
- no-cache
8292
Referrer-Policy:
83-
- no-referrer
93+
- same-origin
8494
Vary:
8595
- Origin
8696
- Access-Control-Request-Method
8797
- Access-Control-Request-Headers
8898
X-Content-Type-Options:
8999
- nosniff
100+
X-Frame-Options:
101+
- SAMEORIGIN
90102
X-GDC-TRACE-ID: *id001
91103
X-Xss-Protection:
92-
- '0'
104+
- 1; mode=block
93105
body:
94106
string: ''
95107
- request:
@@ -119,19 +131,25 @@ interactions:
119131
DATE: *id001
120132
Expires:
121133
- '0'
134+
Featurepolicy:
135+
- geolocation 'none'; midi 'none'; notifications 'none'; push 'none'; sync-xhr
136+
'none'; microphone 'none'; camera 'none'; magnetometer 'none'; gyroscope
137+
'none'; speaker 'none'; vibrate 'none'; fullscreen 'none'; payment 'none';
122138
Pragma:
123139
- no-cache
124140
Referrer-Policy:
125-
- no-referrer
141+
- same-origin
126142
Vary:
127143
- Origin
128144
- Access-Control-Request-Method
129145
- Access-Control-Request-Headers
130146
X-Content-Type-Options:
131147
- nosniff
148+
X-Frame-Options:
149+
- SAMEORIGIN
132150
X-GDC-TRACE-ID: *id001
133151
X-Xss-Protection:
134-
- '0'
152+
- 1; mode=block
135153
body:
136154
string:
137155
notificationChannels:
@@ -171,19 +189,25 @@ interactions:
171189
DATE: *id001
172190
Expires:
173191
- '0'
192+
Featurepolicy:
193+
- geolocation 'none'; midi 'none'; notifications 'none'; push 'none'; sync-xhr
194+
'none'; microphone 'none'; camera 'none'; magnetometer 'none'; gyroscope
195+
'none'; speaker 'none'; vibrate 'none'; fullscreen 'none'; payment 'none';
174196
Pragma:
175197
- no-cache
176198
Referrer-Policy:
177-
- no-referrer
199+
- same-origin
178200
Vary:
179201
- Origin
180202
- Access-Control-Request-Method
181203
- Access-Control-Request-Headers
182204
X-Content-Type-Options:
183205
- nosniff
206+
X-Frame-Options:
207+
- SAMEORIGIN
184208
X-GDC-TRACE-ID: *id001
185209
X-Xss-Protection:
186-
- '0'
210+
- 1; mode=block
187211
body:
188212
string: ''
189213
- request:
@@ -213,19 +237,25 @@ interactions:
213237
DATE: *id001
214238
Expires:
215239
- '0'
240+
Featurepolicy:
241+
- geolocation 'none'; midi 'none'; notifications 'none'; push 'none'; sync-xhr
242+
'none'; microphone 'none'; camera 'none'; magnetometer 'none'; gyroscope
243+
'none'; speaker 'none'; vibrate 'none'; fullscreen 'none'; payment 'none';
216244
Pragma:
217245
- no-cache
218246
Referrer-Policy:
219-
- no-referrer
247+
- same-origin
220248
Vary:
221249
- Origin
222250
- Access-Control-Request-Method
223251
- Access-Control-Request-Headers
224252
X-Content-Type-Options:
225253
- nosniff
254+
X-Frame-Options:
255+
- SAMEORIGIN
226256
X-GDC-TRACE-ID: *id001
227257
X-Xss-Protection:
228-
- '0'
258+
- 1; mode=block
229259
body:
230260
string:
231261
notificationChannels: []

0 commit comments

Comments
 (0)