Skip to content

Commit c66c70f

Browse files
committed
fix: Start adding stuff for nulls
risk: low
1 parent af7d275 commit c66c70f

File tree

4 files changed

+29
-18
lines changed

4 files changed

+29
-18
lines changed

packages/gooddata-sdk/tests/catalog/expected/declarative_ldm_with_sql_dataset.json

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
"description": "Campaign channel id",
4141
"tags": [
4242
"Campaign channels"
43-
]
43+
],
44+
"isNullable": false
4445
},
4546
{
4647
"id": "campaign_channels.category",
@@ -51,7 +52,8 @@
5152
"description": "Category",
5253
"tags": [
5354
"Campaign channels"
54-
]
55+
],
56+
"isNullable": true
5557
},
5658
{
5759
"id": "type",
@@ -62,7 +64,8 @@
6264
"description": "Type",
6365
"tags": [
6466
"Campaign channels"
65-
]
67+
],
68+
"isNullable": true
6669
}
6770
],
6871
"facts": [
@@ -74,7 +77,8 @@
7477
"description": "Budget",
7578
"tags": [
7679
"Campaign channels"
77-
]
80+
],
81+
"isNullable": true
7882
},
7983
{
8084
"id": "spend",
@@ -84,7 +88,8 @@
8488
"description": "Spend",
8589
"tags": [
8690
"Campaign channels"
87-
]
91+
],
92+
"isNullable": true
8893
}
8994
],
9095
"dataSourceTableId": {

packages/gooddata-sdk/tests/catalog/expected/declarative_pdm_ldm_request.json

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,14 @@
55
{
66
"data_type": "NUMERIC",
77
"isPrimaryKey": false,
8-
"name": "budget"
8+
"name": "budget",
9+
"isNullable": true
910
},
1011
{
1112
"data_type": "STRING",
1213
"isPrimaryKey": true,
13-
"name": "campaign_channel_id"
14+
"name": "campaign_channel_id",
15+
"isNullable": false
1416
},
1517
{
1618
"data_type": "INT",
@@ -22,17 +24,20 @@
2224
{
2325
"data_type": "STRING",
2426
"isPrimaryKey": false,
25-
"name": "category"
27+
"name": "category",
28+
"isNullable": true
2629
},
2730
{
2831
"data_type": "NUMERIC",
2932
"isPrimaryKey": false,
30-
"name": "spend"
33+
"name": "spend",
34+
"isNullable": true
3135
},
3236
{
3337
"data_type": "STRING",
3438
"isPrimaryKey": false,
35-
"name": "type"
39+
"name": "type",
40+
"isNullable": true
3641
}
3742
],
3843
"id": "campaign_channels",

packages/gooddata-sdk/tests/catalog/load/gooddata_layouts/default/workspaces/demo/ldm/datasets/customers.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ attributes:
3232
id: geo__state__location
3333
sourceColumn: geo__state__location
3434
sourceColumnDataType: STRING
35-
locale: en-US
36-
translations:
37-
- locale: cs-CZ
38-
sourceColumn: geo__state__location_cz
3935
tags:
4036
- Customers
4137
title: Location

packages/tests-support/fixtures/demo_declarative_hierarchy.json

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2519,6 +2519,7 @@
25192519
"labels": [],
25202520
"sourceColumn": "campaign_channel_id",
25212521
"sourceColumnDataType": "STRING",
2522+
"isNullable": false,
25222523
"tags": [
25232524
"Campaign channels"
25242525
],
@@ -2533,7 +2534,8 @@
25332534
"tags": [
25342535
"Campaign channels"
25352536
],
2536-
"title": "Category"
2537+
"title": "Category",
2538+
"isNullable": true
25372539
},
25382540
{
25392541
"description": "Type",
@@ -2544,7 +2546,8 @@
25442546
"tags": [
25452547
"Campaign channels"
25462548
],
2547-
"title": "Type"
2549+
"title": "Type",
2550+
"isNullable": true
25482551
}
25492552
],
25502553
"dataSourceTableId": {
@@ -2566,7 +2569,8 @@
25662569
"tags": [
25672570
"Campaign channels"
25682571
],
2569-
"title": "Budget"
2572+
"title": "Budget",
2573+
"isNullable": true
25702574
},
25712575
{
25722576
"description": "Spend",
@@ -2576,7 +2580,8 @@
25762580
"tags": [
25772581
"Campaign channels"
25782582
],
2579-
"title": "Spend"
2583+
"title": "Spend",
2584+
"isNullable": true
25802585
}
25812586
],
25822587
"grain": [

0 commit comments

Comments
 (0)