Skip to content

Commit 07890bf

Browse files
committed
feat(catalog): add description field to column models
Add optional description field to SqlColumn and CatalogDeclarativeColumn to support database column comments. This enables passing column descriptions from scanModel API to LDM generation. risk: low jira: DX-312
1 parent e1d6ad4 commit 07890bf

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

  • packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source

packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/action_model/sql_column.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
class SqlColumn(Base):
1212
data_type: str
1313
name: str
14+
description: str | None = None
1415

1516
@staticmethod
1617
def client_class() -> type[ApiSqlColumn]:

packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/declarative_model/physical_model/column.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
class CatalogDeclarativeColumn(Base):
1212
name: str
1313
data_type: str
14+
description: str | None = None
1415
is_primary_key: bool | None = None
1516
referenced_table_id: str | None = None
1617
referenced_table_column: str | None = None

0 commit comments

Comments
 (0)