Skip to content

Commit 19f8c81

Browse files
authored
Merge pull request #91 from gooddata/footer-buttons
DP-3276 Accessibility issues in documentation/website footer
2 parents 5d4de09 + 308e8b0 commit 19f8c81

1 file changed

Lines changed: 11 additions & 28 deletions

File tree

layouts/partials/footer.html

Lines changed: 11 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,12 @@
99
<ul class="gd-footer-banner-links gd-footer-links">
1010
{{ range $index, $link := $footer.footer.bannerLinks }}
1111
<li class="gd-footer-banner-links-item gd-footer-links-item">
12-
<input
13-
type="checkbox"
14-
tabindex="-1"
15-
id="gd-footer-banner-links-item-trigger-{{ $index }}"
16-
name="gd-footer-banner-links-item-trigger-{{ $index }}"
17-
class="gd-footer-banner-links-item-trigger gd-footer-links-item-trigger"
18-
/>
19-
<label
20-
for="gd-footer-banner-links-item-trigger-{{ $index }}"
21-
class="gd-footer-banner-links-item-text gd-footer-links-item-text"
22-
>
23-
{{ $link.title }}
24-
</label>
12+
<span class="gd-footer-banner-links-item-text gd-footer-links-item-text d-none d-lg-block">{{ $link.title }}</span>
13+
<button class="gd-footer-banner-links-item-text gd-footer-links-item-text btn d-lg-none collapsed" type="button" data-bs-toggle="collapse" data-bs-target="#gd-footer-banner-sublinks-item-{{ $index }}" aria-expanded="false" aria-controls="gd-footer-banner-sublinks-item-{{ $index }}">
14+
{{ $link.title }}
15+
</button>
2516
{{ if and $link.items (gt (len $link.items) 0) }}
26-
<ul class="gd-footer-banner-sublinks gd-footer-sublinks">
17+
<ul class="gd-footer-banner-sublinks gd-footer-sublinks collapse d-lg-flex" id="gd-footer-banner-sublinks-item-{{ $index }}">
2718
{{ range $sublink := $link.items }}
2819
<li class="gd-footer-banner-sublinks-item gd-footer-sublinks-item">
2920
{{ if and $sublink.link $sublink.title }}
@@ -43,21 +34,13 @@
4334
<ul class="gd-footer-links">
4435
{{ range $index, $link := $footer.footer.links }}
4536
<li class="gd-footer-links-item">
46-
<input
47-
type="checkbox"
48-
tabindex="-1"
49-
id="gd-footer-links-item-trigger-{{ $index }}"
50-
name="gd-footer-links-item-trigger-{{ $index }}"
51-
class="gd-footer-links-item-trigger"
52-
/>
53-
<label
54-
for="gd-footer-links-item-trigger-{{ $index }}"
55-
class="gd-footer-links-item-text"
56-
>
57-
{{ $link.title }}
58-
</label>
37+
<span class="gd-footer-links-item-text d-none d-lg-block">{{ $link.title }}</span>
38+
<button class="gd-footer-links-item-text btn d-lg-none collapsed" type="button" data-bs-toggle="collapse" data-bs-target="#gd-footer-links-item-{{ $index }}" aria-expanded="false" aria-controls="gd-footer-links-item-{{ $index }}">
39+
{{ $link.title }}
40+
</button>
41+
5942
{{ if and $link.items (gt (len $link.items) 0) }}
60-
<ul class="gd-footer-sublinks">
43+
<ul class="gd-footer-sublinks collapse d-lg-block" id="gd-footer-links-item-{{ $index }}">
6144
{{ range $sublink := $link.items }}
6245
<li class="gd-footer-sublinks-item">
6346
{{ if and $sublink.link $sublink.title }}

0 commit comments

Comments
 (0)