refactor(go-oidc): flatten nested if in maskToken#29
Merged
Conversation
- Move the empty-string guard to the top of maskToken - Read as a flat guard chain instead of nested conditionals
There was a problem hiding this comment.
Pull request overview
This PR refactors the maskToken helper in the go-oidc example by flattening a nested if into an early-return guard, keeping the masking behavior the same while improving readability.
Changes:
- Refactored
maskTokento return early for the empty-string case instead of checking it inside thelen(s) <= 8branch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flattens the nested
ifinmaskToken(go-oidc example) into a top-to-bottom guard chain. Pure readability refactor — no behavior change: empty string →"", 1–8 chars →****, longer →prefix....AI Authorship
go-oidc/main.gomaskTokenchange closely.Change classification
maskTokenis a small log-masking helper in a standalone example program; failure is local to that example.Plan reference
No plan — this came out of a codebase-wide simplification pass. Goal: improve clarity without altering behavior.
Verification
go build ./...andgo vet ./...pass in the go-oidc module."", a short token (≤8 chars), and a long token (>8 chars).Verifiability check
Risk & rollback
0a6f85d.Reviewer guide
maskTokeningo-oidc/main.go— verify the three branches still cover empty / short / long identically to before.🤖 Generated with Claude Code