Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Commit 4b4b15c

Browse files
committed
clean up second step a bit
1 parent 837455e commit 4b4b15c

File tree

4 files changed

+12
-22
lines changed

4 files changed

+12
-22
lines changed

config.yml

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ template:
2323
# 3. (Issue) Create an issue comment with GitHub Script
2424
# secondIssueNumber
2525
# secondIssueUrl
26+
# 4. (PR) Learner created PR, "Add issues to project board" possibly
27+
# secondPullNumber
28+
# secondPullUrl
2629

2730
before:
2831
- type: updateBranchProtection
@@ -95,7 +98,7 @@ steps:
9598
issue: "%registration.store.welcomeIssueNumber%"
9699
with: new-pull-request.md
97100
data:
98-
pullUrl: "%registration.store.firstPullUrl%"
101+
pullurl: '{{ store.firstPullUrl }}'
99102
- type: closeIssue
100103
issue: "%registration.store.welcomeIssueNumber%"
101104
- type: createReview
@@ -129,7 +132,7 @@ steps:
129132
with: new-issue.md
130133
issue: "%registration.store.firstPullNumber%"
131134
data:
132-
issueURL: "%registration.store.secondIssueUrl%"
135+
issueUrl: '{{ store.secondIssueUrl }}'
133136

134137
- title: Add another GitHub Script action
135138
description: Use GitHub Script to place this issue into a project board
@@ -175,29 +178,16 @@ steps:
175178
- pull_request.edited
176179
link: "{{ store.secondIssueUrl }}"
177180
actions:
178-
- type: gate
179-
store:
180-
secondPullNumber: "%payload.pull_request.number%"
181-
secondPullUrl: "%payload.pull_request.html_url%"
182-
left: "%payload.pull_request.title%"
183-
operator: ===
184-
185-
right: Add issues to project board
186-
187-
# if those statments FAIL... do this
188-
else:
189-
- type: respond
190-
with: e-rename-pr.md
191-
data:
192-
title: Add issues to project board
193-
# if those gates === true Then do this stuff
194181
#######################################################
195182
# Validate the filepath for the my-workflow.yml file
196183
# get tree
197184
- type: getTree
198185
action_id: isInTree
199186
recursive: true
200187
sha: "%payload.pull_request.head.sha%"
188+
store:
189+
secondPullNumber: "%payload.pull_request.number%"
190+
secondPullUrl: "%payload.pull_request.html_url%"
201191
# check for a file in a tree
202192
- type: gate
203193
left: "%actions.isInTree.data.tree%"

responses/00_welcome-activity.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Your repository can contain multiple **workflow** files that carry out a wide va
5050
5151
1. Commit the workflow to a new branch.
5252
1. Create a pull request. I suggest a title like **Automate issue responses**.
53-
1. Supply the pull request body content and click `Create pull request`.
53+
1. Supply the pull request body content and click **Create pull request**.
5454
5555
<details><summary>About pull pull request titles and content</summary>
5656

responses/03_add-to-projects.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ We've gone ahead and done this on our end of things so that we could give you th
4545
```
4646
4747
2. Commit the workflow to a new branch.
48-
3. Create a pull request titled **Add issues to project board**.
49-
4. Supply the pull request body content and click `Create pull request`.
48+
3. Create a pull request, I suggest the title **Add issues to project board**.
49+
4. Supply the pull request body content and click **Create pull request**.
5050
5151
---
5252

responses/new-issue.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
## A new issue has been opened
22

3-
I have created a [new issue]({{issueURL}}) where we will continue this lesson. Click the link to meet me over there.
3+
I have created a [new issue]({{issueUrl}}) where we will continue this lesson. Click the link to meet me over there.

0 commit comments

Comments
 (0)