Skip to content

generate_native_pr_trigger returns "" when on.pr has only filters: #385

@jamesadevine

Description

@jamesadevine

src/compile/pr_filters.rs — when PrTriggerConfig has no branches/paths (only filters), generate_native_pr_trigger returns String::new(). This cascades up through generate_pr_trigger as an empty string. The effect is that no pr: block appears in the output YAML, which falls back to ADO repo-level defaults. This is probably the right behavior (let all PRs through the native trigger, then gate via the evaluator), but it's implicit. A comment explaining this is intentional would help readers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions