Skip to content

Commit 04e1d12

Browse files
committed
Restrict sim_hash constants to module visibility
1 parent ebc338c commit 04e1d12

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

crates/geo_filters/src/diff_count.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ mod sim_hash;
1818

1919
use bitvec::*;
2020
pub use config::{GeoDiffConfig13, GeoDiffConfig7};
21-
pub use sim_hash::{SimHash, SIM_BUCKETS, SIM_BUCKET_SIZE};
21+
pub use sim_hash::SimHash;
2222

2323
/// Diff count filter with a relative error standard deviation of ~0.125.
2424
pub type GeoDiffCount7<'a> = GeoDiffCount<'a, GeoDiffConfig7>;

crates/geo_filters/src/diff_count/sim_hash.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ use crate::Diff;
1212
use super::BitVec;
1313

1414
// TODO migrate these const values to be defined in configuration
15-
// The current values are only really appropriate for smaller
16-
// configurations
15+
// The current values are only really appropriate for the smaller
16+
// diff configuration.
1717

1818
/// Number of bits covered by each SimHash bucket.
19-
pub const SIM_BUCKET_SIZE: usize = 6;
19+
const SIM_BUCKET_SIZE: usize = 6;
2020
/// Number of consecutive SimHash buckets used for searching.
21-
pub const SIM_BUCKETS: usize = 20;
21+
const SIM_BUCKETS: usize = 20;
2222

2323
pub type BucketId = usize;
2424

0 commit comments

Comments
 (0)