actually check that a domains dns resolves

Author: benbalter

lib/github-pages-health-check.rb

@@ -81,7 +81,7 @@ def dns
 
     # Are we even able to get the DNS record?
     def dns?
-      !dns.nil?
+      !dns.nil? && !dns.empty?
     end
     alias_method :dns_resolves?, :dns
 

spec/github_pages_health_check_spec.rb

@@ -293,5 +293,10 @@ def cname_packet(domain)
       allow(health_check).to receive(:dns) { nil }
       expect(health_check.dns?).to be(false)
     end
+
+    it "knows when a domain has no record" do
+      allow(health_check).to receive(:domain) { "example.invalid" }
+      expect(health_check.dns?).to be(false)
+    end
   end
 end