Skip to content

Commit 7d46f8d

Browse files
authored
I want to enable only ifc (#2565)
* I want to enable only ifc * Fix tests
1 parent 6e0af32 commit 7d46f8d

3 files changed

Lines changed: 4 additions & 10 deletions

File tree

pkg/github/feature_flags.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ const FeatureFlagIssueFields = "remote_mcp_issue_fields"
2323
var AllowedFeatureFlags = []string{
2424
MCPAppsFeatureFlag,
2525
FeatureFlagCSVOutput,
26+
FeatureFlagIFCLabels,
2627
FeatureFlagIssueFields,
2728
FeatureFlagIssuesGranular,
2829
FeatureFlagPullRequestsGranular,

pkg/github/feature_flags_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ func TestResolveFeatureFlags(t *testing.T) {
148148
name: "no features, no insiders",
149149
enabledFeatures: nil,
150150
expectedFlags: nil,
151-
unexpectedFlags: []string{MCPAppsFeatureFlag, FeatureFlagIFCLabels},
151+
unexpectedFlags: []string{MCPAppsFeatureFlag},
152152
},
153153
{
154154
name: "explicit feature enabled",
@@ -168,10 +168,9 @@ func TestResolveFeatureFlags(t *testing.T) {
168168
expectedFlags: []string{FeatureFlagIFCLabels},
169169
},
170170
{
171-
name: "internal-only flags are not directly enabled",
171+
name: "ifc_labels can be directly enabled",
172172
enabledFeatures: []string{FeatureFlagIFCLabels},
173-
expectedFlags: nil,
174-
unexpectedFlags: []string{FeatureFlagIFCLabels},
173+
expectedFlags: []string{FeatureFlagIFCLabels},
175174
},
176175
{
177176
name: "unknown flags are filtered out",

pkg/http/server_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,6 @@ func TestCreateHTTPFeatureChecker(t *testing.T) {
8787
headerFeatures: []string{github.FeatureFlagIssuesGranular},
8888
wantEnabled: true,
8989
},
90-
{
91-
name: "internal-only flag in header is ignored",
92-
flagName: github.FeatureFlagIFCLabels,
93-
headerFeatures: []string{github.FeatureFlagIFCLabels},
94-
wantEnabled: false,
95-
},
9690
{
9791
name: "static insiders enables insiders flags without route context",
9892
staticInsiders: true,

0 commit comments

Comments
 (0)