Skip to content

Commit f1d3432

Browse files
committed
Rust: Update expected files
1 parent 4c7f394 commit f1d3432

File tree

4 files changed

+48
-9
lines changed

4 files changed

+48
-9
lines changed

rust/ql/test/library-tests/dataflow/global/inline-flow.expected

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,13 @@ edges
184184
| main.rs:306:30:306:56 | ...::take_second(...) [MyInt] | main.rs:306:9:306:26 | MyInt {...} [MyInt] | provenance | |
185185
| main.rs:306:55:306:55 | b [MyInt] | main.rs:293:26:293:37 | ...: MyInt [MyInt] | provenance | |
186186
| main.rs:306:55:306:55 | b [MyInt] | main.rs:306:30:306:56 | ...::take_second(...) [MyInt] | provenance | |
187+
| main.rs:315:32:319:1 | { ... } | main.rs:322:13:322:26 | async_source(...) | provenance | |
187188
| main.rs:315:32:319:1 | { ... } | main.rs:334:41:334:54 | async_source(...) | provenance | |
188189
| main.rs:316:9:316:9 | a | main.rs:315:32:319:1 | { ... } | provenance | |
189190
| main.rs:316:9:316:9 | a | main.rs:317:10:317:10 | a | provenance | |
190191
| main.rs:316:13:316:21 | source(...) | main.rs:316:9:316:9 | a | provenance | |
192+
| main.rs:322:9:322:9 | a | main.rs:323:10:323:10 | a | provenance | |
193+
| main.rs:322:13:322:26 | async_source(...) | main.rs:322:9:322:9 | a | provenance | |
191194
| main.rs:326:13:326:13 | c | main.rs:327:14:327:14 | c | provenance | |
192195
| main.rs:326:17:326:25 | source(...) | main.rs:326:13:326:13 | c | provenance | |
193196
| main.rs:334:9:334:9 | a | main.rs:335:10:335:10 | a | provenance | |
@@ -417,6 +420,9 @@ nodes
417420
| main.rs:316:9:316:9 | a | semmle.label | a |
418421
| main.rs:316:13:316:21 | source(...) | semmle.label | source(...) |
419422
| main.rs:317:10:317:10 | a | semmle.label | a |
423+
| main.rs:322:9:322:9 | a | semmle.label | a |
424+
| main.rs:322:13:322:26 | async_source(...) | semmle.label | async_source(...) |
425+
| main.rs:323:10:323:10 | a | semmle.label | a |
420426
| main.rs:326:13:326:13 | c | semmle.label | c |
421427
| main.rs:326:17:326:25 | source(...) | semmle.label | source(...) |
422428
| main.rs:327:14:327:14 | c | semmle.label | c |
@@ -500,6 +506,7 @@ testFailures
500506
| main.rs:302:10:302:10 | c | main.rs:299:28:299:36 | source(...) | main.rs:302:10:302:10 | c | $@ | main.rs:299:28:299:36 | source(...) | source(...) |
501507
| main.rs:307:10:307:10 | c | main.rs:305:28:305:37 | source(...) | main.rs:307:10:307:10 | c | $@ | main.rs:305:28:305:37 | source(...) | source(...) |
502508
| main.rs:317:10:317:10 | a | main.rs:316:13:316:21 | source(...) | main.rs:317:10:317:10 | a | $@ | main.rs:316:13:316:21 | source(...) | source(...) |
509+
| main.rs:323:10:323:10 | a | main.rs:316:13:316:21 | source(...) | main.rs:323:10:323:10 | a | $@ | main.rs:316:13:316:21 | source(...) | source(...) |
503510
| main.rs:327:14:327:14 | c | main.rs:326:17:326:25 | source(...) | main.rs:327:14:327:14 | c | $@ | main.rs:326:17:326:25 | source(...) | source(...) |
504511
| main.rs:335:10:335:10 | a | main.rs:316:13:316:21 | source(...) | main.rs:335:10:335:10 | a | $@ | main.rs:316:13:316:21 | source(...) | source(...) |
505512
| main.rs:384:14:384:15 | n1 | main.rs:359:13:359:21 | source(...) | main.rs:384:14:384:15 | n1 | $@ | main.rs:359:13:359:21 | source(...) | source(...) |

rust/ql/test/library-tests/dataflow/global/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ async fn async_source() -> i64 {
320320

321321
async fn test_async_await_async_part() {
322322
let a = async_source().await;
323-
sink(a); // $ MISSING: hasValueFlow=1
323+
sink(a); // $ hasTaintFlow=1 MISSING: hasValueFlow=1
324324

325325
let b = async {
326326
let c = source(2);

rust/ql/test/library-tests/dataflow/sources/database/InlineFlow.expected

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,9 @@ edges
5151
| test.rs:48:22:48:30 | query_map | test.rs:50:14:50:24 | ...: i64 | provenance | Src:MaD:3 |
5252
| test.rs:50:14:50:24 | ...: i64 | test.rs:51:22:51:27 | values | provenance | |
5353
| test.rs:55:22:55:30 | query_map | test.rs:57:14:57:39 | ...: ... | provenance | Src:MaD:3 |
54+
| test.rs:57:14:57:39 | ...: ... | test.rs:58:22:58:29 | values.0 | provenance | |
5455
| test.rs:57:14:57:39 | ...: ... | test.rs:59:22:59:29 | values.1 | provenance | |
56+
| test.rs:57:14:57:39 | ...: ... | test.rs:60:22:60:29 | values.2 | provenance | |
5557
| test.rs:64:13:64:17 | total | test.rs:68:14:68:18 | total | provenance | |
5658
| test.rs:64:21:67:10 | conn.query_fold(...) [Ok] | test.rs:64:21:67:11 | TryExpr | provenance | |
5759
| test.rs:64:21:67:11 | TryExpr | test.rs:64:13:64:17 | total | provenance | |
@@ -64,8 +66,12 @@ edges
6466
| test.rs:66:19:66:21 | row | test.rs:66:13:66:21 | ... + ... | provenance | MaD:12 |
6567
| test.rs:66:19:66:21 | row | test.rs:66:13:66:21 | ... + ... | provenance | MaD:15 |
6668
| test.rs:70:22:70:31 | query_fold | test.rs:70:83:70:105 | ...: ... | provenance | Src:MaD:2 |
69+
| test.rs:70:83:70:105 | ...: ... | test.rs:71:17:71:18 | id | provenance | |
6770
| test.rs:70:83:70:105 | ...: ... | test.rs:72:17:72:20 | name | provenance | |
71+
| test.rs:70:83:70:105 | ...: ... | test.rs:73:17:73:19 | age | provenance | |
72+
| test.rs:71:17:71:18 | id | test.rs:74:18:74:19 | id | provenance | |
6873
| test.rs:72:17:72:20 | name | test.rs:75:18:75:21 | name | provenance | |
74+
| test.rs:73:17:73:19 | age | test.rs:76:18:76:20 | age | provenance | |
6975
| test.rs:105:13:105:14 | v1 | test.rs:106:14:106:15 | v1 | provenance | |
7076
| test.rs:105:24:105:33 | row.get(...) [Some] | test.rs:105:24:105:42 | ... .unwrap() | provenance | MaD:16 |
7177
| test.rs:105:24:105:42 | ... .unwrap() | test.rs:105:13:105:14 | v1 | provenance | |
@@ -87,7 +93,9 @@ edges
8793
| test.rs:135:22:135:30 | query_map | test.rs:137:14:137:24 | ...: i64 | provenance | Src:MaD:5 |
8894
| test.rs:137:14:137:24 | ...: i64 | test.rs:138:22:138:27 | values | provenance | |
8995
| test.rs:142:22:142:30 | query_map | test.rs:144:14:144:39 | ...: ... | provenance | Src:MaD:5 |
96+
| test.rs:144:14:144:39 | ...: ... | test.rs:145:22:145:29 | values.0 | provenance | |
9097
| test.rs:144:14:144:39 | ...: ... | test.rs:146:22:146:29 | values.1 | provenance | |
98+
| test.rs:144:14:144:39 | ...: ... | test.rs:147:22:147:29 | values.2 | provenance | |
9199
| test.rs:151:13:151:17 | total | test.rs:155:14:155:18 | total | provenance | |
92100
| test.rs:151:21:154:10 | conn.query_fold(...) [future, Ok] | test.rs:151:21:154:16 | await ... [Ok] | provenance | |
93101
| test.rs:151:21:154:16 | await ... [Ok] | test.rs:151:21:154:17 | TryExpr | provenance | |
@@ -101,8 +109,12 @@ edges
101109
| test.rs:153:19:153:21 | row | test.rs:153:13:153:21 | ... + ... | provenance | MaD:12 |
102110
| test.rs:153:19:153:21 | row | test.rs:153:13:153:21 | ... + ... | provenance | MaD:15 |
103111
| test.rs:157:22:157:31 | query_fold | test.rs:157:83:157:105 | ...: ... | provenance | Src:MaD:4 |
112+
| test.rs:157:83:157:105 | ...: ... | test.rs:158:17:158:18 | id | provenance | |
104113
| test.rs:157:83:157:105 | ...: ... | test.rs:159:17:159:20 | name | provenance | |
114+
| test.rs:157:83:157:105 | ...: ... | test.rs:160:17:160:19 | age | provenance | |
115+
| test.rs:158:17:158:18 | id | test.rs:161:18:161:19 | id | provenance | |
105116
| test.rs:159:17:159:20 | name | test.rs:162:18:162:21 | name | provenance | |
117+
| test.rs:160:17:160:19 | age | test.rs:163:18:163:20 | age | provenance | |
106118
nodes
107119
| test.rs:18:13:18:14 | v1 | semmle.label | v1 |
108120
| test.rs:18:24:18:33 | row.get(...) [Some] | semmle.label | row.get(...) [Some] |
@@ -147,7 +159,9 @@ nodes
147159
| test.rs:51:22:51:27 | values | semmle.label | values |
148160
| test.rs:55:22:55:30 | query_map | semmle.label | query_map |
149161
| test.rs:57:14:57:39 | ...: ... | semmle.label | ...: ... |
162+
| test.rs:58:22:58:29 | values.0 | semmle.label | values.0 |
150163
| test.rs:59:22:59:29 | values.1 | semmle.label | values.1 |
164+
| test.rs:60:22:60:29 | values.2 | semmle.label | values.2 |
151165
| test.rs:64:13:64:17 | total | semmle.label | total |
152166
| test.rs:64:21:67:10 | conn.query_fold(...) [Ok] | semmle.label | conn.query_fold(...) [Ok] |
153167
| test.rs:64:21:67:11 | TryExpr | semmle.label | TryExpr |
@@ -160,8 +174,12 @@ nodes
160174
| test.rs:68:14:68:18 | total | semmle.label | total |
161175
| test.rs:70:22:70:31 | query_fold | semmle.label | query_fold |
162176
| test.rs:70:83:70:105 | ...: ... | semmle.label | ...: ... |
177+
| test.rs:71:17:71:18 | id | semmle.label | id |
163178
| test.rs:72:17:72:20 | name | semmle.label | name |
179+
| test.rs:73:17:73:19 | age | semmle.label | age |
180+
| test.rs:74:18:74:19 | id | semmle.label | id |
164181
| test.rs:75:18:75:21 | name | semmle.label | name |
182+
| test.rs:76:18:76:20 | age | semmle.label | age |
165183
| test.rs:105:13:105:14 | v1 | semmle.label | v1 |
166184
| test.rs:105:24:105:33 | row.get(...) [Some] | semmle.label | row.get(...) [Some] |
167185
| test.rs:105:24:105:42 | ... .unwrap() | semmle.label | ... .unwrap() |
@@ -189,7 +207,9 @@ nodes
189207
| test.rs:138:22:138:27 | values | semmle.label | values |
190208
| test.rs:142:22:142:30 | query_map | semmle.label | query_map |
191209
| test.rs:144:14:144:39 | ...: ... | semmle.label | ...: ... |
210+
| test.rs:145:22:145:29 | values.0 | semmle.label | values.0 |
192211
| test.rs:146:22:146:29 | values.1 | semmle.label | values.1 |
212+
| test.rs:147:22:147:29 | values.2 | semmle.label | values.2 |
193213
| test.rs:151:13:151:17 | total | semmle.label | total |
194214
| test.rs:151:21:154:10 | conn.query_fold(...) [future, Ok] | semmle.label | conn.query_fold(...) [future, Ok] |
195215
| test.rs:151:21:154:16 | await ... [Ok] | semmle.label | await ... [Ok] |
@@ -203,8 +223,12 @@ nodes
203223
| test.rs:155:14:155:18 | total | semmle.label | total |
204224
| test.rs:157:22:157:31 | query_fold | semmle.label | query_fold |
205225
| test.rs:157:83:157:105 | ...: ... | semmle.label | ...: ... |
226+
| test.rs:158:17:158:18 | id | semmle.label | id |
206227
| test.rs:159:17:159:20 | name | semmle.label | name |
228+
| test.rs:160:17:160:19 | age | semmle.label | age |
229+
| test.rs:161:18:161:19 | id | semmle.label | id |
207230
| test.rs:162:18:162:21 | name | semmle.label | name |
231+
| test.rs:163:18:163:20 | age | semmle.label | age |
208232
subpaths
209233
testFailures
210234
#select
@@ -216,16 +240,24 @@ testFailures
216240
| test.rs:41:14:41:70 | ... .unwrap() | test.rs:41:42:41:44 | get | test.rs:41:14:41:70 | ... .unwrap() | $@ | test.rs:41:42:41:44 | get | get |
217241
| test.rs:44:22:44:22 | v | test.rs:40:27:40:35 | exec_iter | test.rs:44:22:44:22 | v | $@ | test.rs:40:27:40:35 | exec_iter | exec_iter |
218242
| test.rs:51:22:51:27 | values | test.rs:48:22:48:30 | query_map | test.rs:51:22:51:27 | values | $@ | test.rs:48:22:48:30 | query_map | query_map |
243+
| test.rs:58:22:58:29 | values.0 | test.rs:55:22:55:30 | query_map | test.rs:58:22:58:29 | values.0 | $@ | test.rs:55:22:55:30 | query_map | query_map |
219244
| test.rs:59:22:59:29 | values.1 | test.rs:55:22:55:30 | query_map | test.rs:59:22:59:29 | values.1 | $@ | test.rs:55:22:55:30 | query_map | query_map |
245+
| test.rs:60:22:60:29 | values.2 | test.rs:55:22:55:30 | query_map | test.rs:60:22:60:29 | values.2 | $@ | test.rs:55:22:55:30 | query_map | query_map |
220246
| test.rs:65:18:65:20 | row | test.rs:64:26:64:35 | query_fold | test.rs:65:18:65:20 | row | $@ | test.rs:64:26:64:35 | query_fold | query_fold |
221247
| test.rs:68:14:68:18 | total | test.rs:64:26:64:35 | query_fold | test.rs:68:14:68:18 | total | $@ | test.rs:64:26:64:35 | query_fold | query_fold |
248+
| test.rs:74:18:74:19 | id | test.rs:70:22:70:31 | query_fold | test.rs:74:18:74:19 | id | $@ | test.rs:70:22:70:31 | query_fold | query_fold |
222249
| test.rs:75:18:75:21 | name | test.rs:70:22:70:31 | query_fold | test.rs:75:18:75:21 | name | $@ | test.rs:70:22:70:31 | query_fold | query_fold |
250+
| test.rs:76:18:76:20 | age | test.rs:70:22:70:31 | query_fold | test.rs:76:18:76:20 | age | $@ | test.rs:70:22:70:31 | query_fold | query_fold |
223251
| test.rs:106:14:106:15 | v1 | test.rs:105:28:105:30 | get | test.rs:106:14:106:15 | v1 | $@ | test.rs:105:28:105:30 | get | get |
224252
| test.rs:109:14:109:15 | v2 | test.rs:108:28:108:34 | get_opt | test.rs:109:14:109:15 | v2 | $@ | test.rs:108:28:108:34 | get_opt | get_opt |
225253
| test.rs:112:14:112:15 | v3 | test.rs:111:28:111:31 | take | test.rs:112:14:112:15 | v3 | $@ | test.rs:111:28:111:31 | take | take |
226254
| test.rs:115:14:115:15 | v4 | test.rs:114:28:114:35 | take_opt | test.rs:115:14:115:15 | v4 | $@ | test.rs:114:28:114:35 | take_opt | take_opt |
227255
| test.rs:138:22:138:27 | values | test.rs:135:22:135:30 | query_map | test.rs:138:22:138:27 | values | $@ | test.rs:135:22:135:30 | query_map | query_map |
256+
| test.rs:145:22:145:29 | values.0 | test.rs:142:22:142:30 | query_map | test.rs:145:22:145:29 | values.0 | $@ | test.rs:142:22:142:30 | query_map | query_map |
228257
| test.rs:146:22:146:29 | values.1 | test.rs:142:22:142:30 | query_map | test.rs:146:22:146:29 | values.1 | $@ | test.rs:142:22:142:30 | query_map | query_map |
258+
| test.rs:147:22:147:29 | values.2 | test.rs:142:22:142:30 | query_map | test.rs:147:22:147:29 | values.2 | $@ | test.rs:142:22:142:30 | query_map | query_map |
229259
| test.rs:152:18:152:20 | row | test.rs:151:26:151:35 | query_fold | test.rs:152:18:152:20 | row | $@ | test.rs:151:26:151:35 | query_fold | query_fold |
230260
| test.rs:155:14:155:18 | total | test.rs:151:26:151:35 | query_fold | test.rs:155:14:155:18 | total | $@ | test.rs:151:26:151:35 | query_fold | query_fold |
261+
| test.rs:161:18:161:19 | id | test.rs:157:22:157:31 | query_fold | test.rs:161:18:161:19 | id | $@ | test.rs:157:22:157:31 | query_fold | query_fold |
231262
| test.rs:162:18:162:21 | name | test.rs:157:22:157:31 | query_fold | test.rs:162:18:162:21 | name | $@ | test.rs:157:22:157:31 | query_fold | query_fold |
263+
| test.rs:163:18:163:20 | age | test.rs:157:22:157:31 | query_fold | test.rs:163:18:163:20 | age | $@ | test.rs:157:22:157:31 | query_fold | query_fold |

rust/ql/test/library-tests/dataflow/sources/database/test.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ mod test_mysql {
5555
let _ = conn.query_map( // $ Alert[rust/summary/taint-sources]
5656
"SELECT id, name, age FROM person",
5757
|values: (i64, String, i32)| -> () {
58-
sink(values.0); // $ MISSING: hasTaintFlow
58+
sink(values.0); // $ hasTaintFlow
5959
sink(values.1); // $ hasTaintFlow
60-
sink(values.2); // $ MISSING: hasTaintFlow
60+
sink(values.2); // $ hasTaintFlow
6161
}
6262
)?;
6363

@@ -71,9 +71,9 @@ mod test_mysql {
7171
let id: i64 = row.0;
7272
let name: String = row.1;
7373
let age: i32 = row.2;
74-
sink(id); // $ MISSING: hasTaintFlow
74+
sink(id); // $ hasTaintFlow
7575
sink(name); // $ hasTaintFlow
76-
sink(age); // $ MISSING: hasTaintFlow
76+
sink(age); // $ hasTaintFlow
7777
acc + 1
7878
})?;
7979

@@ -142,9 +142,9 @@ mod test_mysql_async {
142142
let _ = conn.query_map( // $ Alert[rust/summary/taint-sources]
143143
"SELECT id, name, age FROM person",
144144
|values: (i64, String, i32)| -> () {
145-
sink(values.0); // $ MISSING: hasTaintFlow
145+
sink(values.0); // $ hasTaintFlow
146146
sink(values.1); // $ hasTaintFlow
147-
sink(values.2); // $ MISSING: hasTaintFlow
147+
sink(values.2); // $ hasTaintFlow
148148
}
149149
).await?;
150150

@@ -158,9 +158,9 @@ mod test_mysql_async {
158158
let id: i64 = row.0;
159159
let name: String = row.1;
160160
let age: i32 = row.2;
161-
sink(id); // $ MISSING: hasTaintFlow
161+
sink(id); // $ hasTaintFlow
162162
sink(name); // $ hasTaintFlow
163-
sink(age); // $ MISSING: hasTaintFlow
163+
sink(age); // $ hasTaintFlow
164164
acc + 1
165165
}).await?;
166166

0 commit comments

Comments
 (0)