Merge pull request #20985 from asgerf/js/overlay-local-optional

JS: Use question-mark variant in all overlay annotations

Author: redsun82

javascript/ql/lib/Expressions/ExprHasNoEffect.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes and predicates for the 'js/useless-expression' query.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/LanguageFeatures/UnusedIndexVariable.qll

@@ -1,7 +1,7 @@
 /**
  * Provides a predicate for identifying unused index variables in loops.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/AMD.qll

@@ -2,7 +2,7 @@
  * Provides classes for working with
  * [Asynchronous Module Definitions](https://github.com/amdjs/amdjs-api/wiki/AMD).
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/AST.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with the AST-based representation of JavaScript programs.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript
@@ -477,7 +477,7 @@ module AST {
     DataFlow::AnalyzedNode analyze() { result = DataFlow::valueNode(this).analyze() }
 
     /** Gets the data flow node associated with this program element. */
-    overlay[caller]
+    overlay[caller?]
     pragma[inline]
     DataFlow::ValueNode flow() { result = DataFlow::valueNode(this) }
 

javascript/ql/lib/semmle/javascript/CFG.qll

@@ -272,7 +272,7 @@
  * Note that the `import` statement as a whole is part of the CFG of the body, while its single
  * import specifier `x as y` forms part of the preamble.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Classes.qll

@@ -4,7 +4,7 @@
  * Class declarations and class expressions are modeled by (QL) classes `ClassDeclaration`
  * and `ClassExpression`, respectively, which are both subclasses of `ClassDefinition`.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Closure.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with the Closure-Library module system.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Comments.qll

@@ -1,5 +1,5 @@
 /** Provides classes for working with JavaScript comments. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Constants.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with expressions that evaluate to constant values.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/DefUse.qll

@@ -1,5 +1,5 @@
 /** Provides classes and predicates for working with variable definitions and uses. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript