JS: Expose hasUnderlyingStringOrAnyType()

Author: asgerf

javascript/ql/lib/semmle/javascript/frameworks/Nest.qll

@@ -337,10 +337,7 @@ module NestJS {
       handler.isReturnValueReflected() and
       this = handler.getAReturn() and
       // Only returned strings are sinks. If we can find a type for the return value, it must be string-like.
-      not exists(NameResolution::Node type |
-        TypeResolution::valueHasType(this.asExpr(), type) and
-        not TypeResolution::hasUnderlyingStringOrAnyType(type)
-      )
+      this.asExpr().getTypeBinding().hasUnderlyingStringOrAnyType()
     }
 
     override Http::RouteHandler getRouteHandler() { result = handler }

javascript/ql/lib/semmle/javascript/internal/BindingInfo.qll

@@ -119,6 +119,11 @@ class TypeNameBindingNode extends NameResolution::Node {
   DataFlow::ClassNode getAnUnderlyingClass() {
     UnderlyingTypes::nodeHasUnderlyingClassType(this, result)
   }
+
+  /**
+   * Holds if this type contains `string` or `any`, possibly wrapped in a promise.
+   */
+  predicate hasUnderlyingStringOrAnyType() { TypeResolution::hasUnderlyingStringOrAnyType(this) }
 }
 
 /**