Skip to content

Commit b08dbe0

Browse files
committed
Address review comments
1 parent c5af080 commit b08dbe0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

rust/ql/lib/codeql/rust/internal/typeinference/FunctionOverloading.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private module MkSiblingImpls<resolveTypeMentionAtSig/2 resolveTypeMentionAt> {
4949
}
5050

5151
/**
52-
* Holds if `impl1` and `impl2` are a sibling implementations of `trait`. We
52+
* Holds if `impl1` and `impl2` are sibling implementations of `trait`. We
5353
* consider implementations to be siblings if they implement the same trait for
5454
* the same type. In that case `Self` is the same type in both implementations,
5555
* and method calls to the implementations cannot be resolved unambiguously
@@ -62,7 +62,7 @@ private module MkSiblingImpls<resolveTypeMentionAtSig/2 resolveTypeMentionAt> {
6262
exists(Type rootType, AstNode selfTy1, AstNode selfTy2 |
6363
implSiblingCandidate(impl1, trait, rootType, selfTy1) and
6464
implSiblingCandidate(impl2, trait, rootType, selfTy2) and
65-
// In principle the second conjunct below should be superflous, but we still
65+
// In principle the second conjunct below should be superfluous, but we still
6666
// have ill-formed type mentions for types that we don't understand. For
6767
// those checking both directions restricts further. Note also that we check
6868
// syntactic equality, whereas equality up to renaming would be more

shared/typeinference/codeql/typeinference/internal/TypeInference.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1194,7 +1194,7 @@ module Make1<LocationSig Location, InputSig1<Location> Input1> {
11941194
predicate dissatisfiesConstraint(Term term, Constraint constraint) {
11951195
hasNotConstraintMention(term, constraint, _) and
11961196
exists(Type t, Type constraintRoot |
1197-
hasTypeConstraint(term, t, constraint, constraintRoot) and // todo
1197+
hasTypeConstraint(term, t, constraint, constraintRoot) and
11981198
t != constraintRoot
11991199
)
12001200
}

0 commit comments

Comments
 (0)