Apply review fixes to AstConsistency.qll

Agent-Logs-Url: https://github.com/github/codeql/sessions/85daaeb0-9115-4937-af69-fbb3be5f3d64

Co-authored-by: aschackmull <28296824+aschackmull@users.noreply.github.com>

Author: Copilot

shared/controlflow/codeql/controlflow/AstConsistency.qll

@@ -9,12 +9,12 @@ private import ControlFlowGraph
 module MakeAstConsistency<LocationSig Location, AstSig<Location> Ast> {
   private import Ast
 
-  private predicate parentStep(AstNode child, AstNode parent) { child = getChild(parent, _) }
+  private AstNode getParent(AstNode child) { child = getChild(result, _) }
 
   private predicate astMemberChild(AstNode parent, AstNode child, string member) {
-    callableGetBody(parent.(Callable)) = child and member = "Callable.getBody"
+    callableGetBody(parent) = child and member = "Callable.getBody"
     or
-    callableGetParameter(parent.(Callable), _) = child and member = "Callable.getParameter"
+    callableGetParameter(parent, _) = child and member = "Callable.getParameter"
     or
     parent.(Parameter).getDefaultValue() = child and member = "Parameter.getDefaultValue"
     or
@@ -56,9 +56,9 @@ module MakeAstConsistency<LocationSig Location, AstSig<Location> Ast> {
     or
     parent.(TryStmt).getFinally() = child and member = "TryStmt.getFinally"
     or
-    getTryInit(parent.(TryStmt), _) = child and member = "getTryInit"
+    getTryInit(parent, _) = child and member = "getTryInit"
     or
-    getTryElse(parent.(TryStmt)) = child and member = "getTryElse"
+    getTryElse(parent) = child and member = "getTryElse"
     or
     parent.(CatchClause).getVariable() = child and member = "CatchClause.getVariable"
     or
@@ -121,6 +121,27 @@ module MakeAstConsistency<LocationSig Location, AstSig<Location> Ast> {
   }
 
   module Consistency {
+    /** Holds if the consistency query `query` has `results` results. */
+    query predicate consistencyOverview(string query, int results) {
+      query = "multipleParents" and
+      results = strictcount(AstNode child | multipleParents(child, _, _))
+      or
+      query = "nonAncestorEnclosingCallable" and
+      results = strictcount(AstNode node | nonAncestorEnclosingCallable(node, _))
+      or
+      query = "childAtMultipleIndices" and
+      results = strictcount(AstNode child | childAtMultipleIndices(_, child, _, _))
+      or
+      query = "siblingsWithIdenticalIndex" and
+      results = strictcount(AstNode parent, int index | siblingsWithIdenticalIndex(parent, index, _, _))
+      or
+      query = "memberChildMissingFromGetChild" and
+      results = strictcount(AstNode parent, AstNode child | memberChildMissingFromGetChild(parent, child, _))
+      or
+      query = "getChildMissingFromMember" and
+      results = strictcount(AstNode parent, int index | getChildMissingFromMember(parent, index, _))
+    }
+
     /** Holds if `child` has multiple AST parents. */
     query predicate multipleParents(AstNode child, AstNode parent1, AstNode parent2) {
       getChild(parent1, _) = child and
@@ -134,7 +155,7 @@ module MakeAstConsistency<LocationSig Location, AstSig<Location> Ast> {
      */
     query predicate nonAncestorEnclosingCallable(AstNode node, Callable callable) {
       callable = getEnclosingCallable(node) and
-      not parentStep*(node, callable)
+      not getParent*(node) = callable
     }
 
     /** Holds if `child` is assigned multiple child indices under `parent`. */