Skip to content

Commit a686e6b

Browse files
committed
feat: Add Client Response Threat Model and update JS Clients
1 parent 8fe2699 commit a686e6b

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* Added support for ClientRequest being part of the `client-response` threat model versus part of `response` threat model.

javascript/ql/lib/semmle/javascript/frameworks/ClientRequests.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ module ClientRequest {
947947
private class ClientRequestThreatModel extends ThreatModelSource::Range {
948948
ClientRequestThreatModel() { this = any(ClientRequest r).getAResponseDataNode() }
949949

950-
override string getThreatModel() { result = "response" }
950+
override string getThreatModel() { result = "client-response" }
951951

952952
override string getSourceType() { result = "HTTP response data" }
953953
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* Add support for `client-response` threat model.

shared/threat-models/ext/threat-model-grouping.model.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ extensions:
1818
- ["stdin", "local"]
1919
- ["file", "local"]
2020
- ["windows-registry", "local"]
21+
# Client-side threat models for request responses.
22+
- ["client-response", "local"]
2123

2224
# Android threat models
2325
- ["android-external-storage-dir", "android"]

0 commit comments

Comments
 (0)