Rust: Suppress type inference inconsistency that can be explained by path resolution

Author: paldepind

rust/ql/lib/codeql/rust/internal/TypeInference.qll

@@ -226,7 +226,13 @@ module Consistency {
 
   predicate nonUniqueCertainType(AstNode n, TypePath path, Type t) {
     strictcount(CertainTypeInference::inferCertainType(n, path)) > 1 and
-    t = CertainTypeInference::inferCertainType(n, path)
+    t = CertainTypeInference::inferCertainType(n, path) and
+    // Suppress the inconsistency if `n` is a self parameter and path resolution
+    // provides multiple targets for the self path of the impl block.
+    not exists(ImplItemNode impl |
+      n = impl.getAnAssocItem().(Function).getParamList().getSelfParam() and
+      count(impl.resolveSelfTy()) > 1
+    )
   }
 }
 
@@ -2467,8 +2473,9 @@ private module Debug {
   private Locatable getRelevantLocatable() {
     exists(string filepath, int startline, int startcolumn, int endline, int endcolumn |
       result.getLocation().hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn) and
-      filepath.matches("%/sqlx.rs") and
-      startline = [56 .. 60]
+      // filepath.matches("%/sort_compare.rs") // and
+      filepath.matches("%/main.rs") // and
+      // startline = [56 .. 60]
     )
   }