Skip to content

Commit 46463ee

Browse files
paldepindpaldepind
committed
Rust: Implement type inference for overloaded operators
1 parent b72a78f commit 46463ee

File tree

6 files changed

+413
-125
lines changed

6 files changed

+413
-125
lines changed

‎rust/ql/lib/codeql/rust/elements/internal/BinaryExprImpl.qll‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@ module Impl {
2828

2929
override string getOperatorName() { result = Generated::BinaryExpr.super.getOperatorName() }
3030

31-
override Expr getAnOperand() { result = [this.getLhs(), this.getRhs()] }
31+
override int getNumberOfOperands() { result = 2 }
32+
33+
override Expr getOperand(int n) {
34+
n = 0 and result = this.getLhs()
35+
or
36+
n = 1 and result = this.getRhs()
37+
}
3238
}
3339
}

‎rust/ql/lib/codeql/rust/elements/internal/OperationImpl.qll‎

Lines changed: 90 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,78 @@
77
private import rust
88
private import codeql.rust.elements.internal.ExprImpl::Impl as ExprImpl
99

10+
/**
11+
* Holds if the given operator is overloaded through the trait `trait` and the
12+
* method name `method`.
13+
*/
14+
private predicate isOverloaded(string op, string path, string method) {
15+
// Negation
16+
op = "-" and path = "core::ops::arith::Neg" and method = "neg"
17+
or
18+
// Not
19+
op = "!" and path = "core::ops::bit::Not" and method = "not"
20+
or
21+
// Dereference
22+
op = "*" and path = "core::ops::Deref" and method = "deref"
23+
or
24+
// Comparison operators
25+
op = "==" and path = "core::cmp::PartialEq" and method = "eq"
26+
or
27+
op = "!=" and path = "core::cmp::PartialEq" and method = "ne"
28+
or
29+
op = "<" and path = "core::cmp::PartialOrd" and method = "lt"
30+
or
31+
op = "<=" and path = "core::cmp::PartialOrd" and method = "le"
32+
or
33+
op = ">" and path = "core::cmp::PartialOrd" and method = "gt"
34+
or
35+
op = ">=" and path = "core::cmp::PartialOrd" and method = "ge"
36+
or
37+
// Arithmetic operators
38+
op = "+" and path = "core::ops::arith::Add" and method = "add"
39+
or
40+
op = "-" and path = "core::ops::arith::Sub" and method = "sub"
41+
or
42+
op = "*" and path = "core::ops::arith::Mul" and method = "mul"
43+
or
44+
op = "/" and path = "core::ops::arith::Div" and method = "div"
45+
or
46+
op = "%" and path = "core::ops::arith::Rem" and method = "rem"
47+
or
48+
// Arithmetic assignment expressions
49+
op = "+=" and path = "core::ops::arith::AddAssign" and method = "add_assign"
50+
or
51+
op = "-=" and path = "core::ops::arith::SubAssign" and method = "sub_assign"
52+
or
53+
op = "*=" and path = "core::ops::arith::MulAssign" and method = "mul_assign"
54+
or
55+
op = "/=" and path = "core::ops::arith::DivAssign" and method = "div_assign"
56+
or
57+
op = "%=" and path = "core::ops::arith::RemAssign" and method = "rem_assign"
58+
or
59+
// Bitwise operators
60+
op = "&" and path = "core::ops::bit::BitAnd" and method = "bitand"
61+
or
62+
op = "|" and path = "core::ops::bit::BitOr" and method = "bitor"
63+
or
64+
op = "^" and path = "core::ops::bit::BitXor" and method = "bitxor"
65+
or
66+
op = "<<" and path = "core::ops::bit::Shl" and method = "shl"
67+
or
68+
op = ">>" and path = "core::ops::bit::Shr" and method = "shr"
69+
or
70+
// Bitwise assignment operators
71+
op = "&=" and path = "core::ops::bit::BitAndAssign" and method = "bitand_assign"
72+
or
73+
op = "|=" and path = "core::ops::bit::BitOrAssign" and method = "bitor_assign"
74+
or
75+
op = "^=" and path = "core::ops::bit::BitXorAssign" and method = "bitxor_assign"
76+
or
77+
op = "<<=" and path = "core::ops::bit::ShlAssign" and method = "shl_assign"
78+
or
79+
op = ">>=" and path = "core::ops::bit::ShrAssign" and method = "shr_assign"
80+
}
81+
1082
/**
1183
* INTERNAL: This module contains the customizable definition of `Operation` and should not
1284
* be referenced directly.
@@ -16,14 +88,28 @@ module Impl {
1688
* An operation, for example `&&`, `+=`, `!` or `*`.
1789
*/
1890
abstract class Operation extends ExprImpl::Expr {
91+
/** Gets the operator name of this operation, if it exists. */
92+
abstract string getOperatorName();
93+
94+
/** Gets the `n`th operand of this operation, if any. */
95+
abstract Expr getOperand(int n);
96+
1997
/**
20-
* Gets the operator name of this operation, if it exists.
98+
* Gets the number of operands of this operation.
99+
*
100+
* This is either 1 for prefix operations, or 2 for binary operations.
21101
*/
22-
abstract string getOperatorName();
102+
abstract int getNumberOfOperands();
103+
104+
/** Gets an operand of this operation. */
105+
Expr getAnOperand() { result = this.getOperand(_) }
23106

24107
/**
25-
* Gets an operand of this operation.
108+
* Holds if this operation is overloaded to the method `methodName` of the
109+
* trait `trait`.
26110
*/
27-
abstract Expr getAnOperand();
111+
predicate isOverloaded(Trait trait, string methodName) {
112+
isOverloaded(this.getOperatorName(), trait.getCanonicalPath(), methodName)
113+
}
28114
}
29115
}

‎rust/ql/lib/codeql/rust/elements/internal/PrefixExprImpl.qll‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ module Impl {
2626

2727
override string getOperatorName() { result = Generated::PrefixExpr.super.getOperatorName() }
2828

29-
override Expr getAnOperand() { result = this.getExpr() }
29+
override int getNumberOfOperands() { result = 1 }
30+
31+
override Expr getOperand(int n) { n = 0 and result = this.getExpr() }
3032
}
3133
}

‎rust/ql/lib/codeql/rust/internal/TypeInference.qll‎

Lines changed: 58 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -645,20 +645,30 @@ private module CallExprBaseMatchingInput implements MatchingInputSig {
645645

646646
private import codeql.rust.elements.internal.CallExprImpl::Impl as CallExprImpl
647647

648-
class Access extends CallExprBase {
648+
abstract class Access extends Expr {
649+
abstract Type getTypeArgument(TypeArgumentPosition apos, TypePath path);
650+
651+
abstract AstNode getNodeAt(AccessPosition apos);
652+
653+
abstract Type getInferredType(AccessPosition apos, TypePath path);
654+
655+
abstract Declaration getTarget();
656+
}
657+
658+
private class CallExprBaseAccess extends Access instanceof CallExprBase {
649659
private TypeReprMention getMethodTypeArg(int i) {
650660
result = this.(MethodCallExpr).getGenericArgList().getTypeArg(i)
651661
}
652662

653-
Type getTypeArgument(TypeArgumentPosition apos, TypePath path) {
663+
override Type getTypeArgument(TypeArgumentPosition apos, TypePath path) {
654664
exists(TypeMention arg | result = arg.resolveTypeAt(path) |
655665
arg = getExplicitTypeArgMention(CallExprImpl::getFunctionPath(this), apos.asTypeParam())
656666
or
657667
arg = this.getMethodTypeArg(apos.asMethodTypeArgumentPosition())
658668
)
659669
}
660670

661-
AstNode getNodeAt(AccessPosition apos) {
671+
override AstNode getNodeAt(AccessPosition apos) {
662672
exists(int p, boolean isMethodCall |
663673
argPos(this, result, p, isMethodCall) and
664674
apos = TPositionalAccessPosition(p, isMethodCall)
@@ -671,17 +681,40 @@ private module CallExprBaseMatchingInput implements MatchingInputSig {
671681
apos = TReturnAccessPosition()
672682
}
673683

674-
Type getInferredType(AccessPosition apos, TypePath path) {
684+
override Type getInferredType(AccessPosition apos, TypePath path) {
675685
result = inferType(this.getNodeAt(apos), path)
676686
}
677687

678-
Declaration getTarget() {
688+
override Declaration getTarget() {
679689
result = CallExprImpl::getResolvedFunction(this)
680690
or
681691
result = inferMethodCallTarget(this) // mutual recursion; resolving method calls requires resolving types and vice versa
682692
}
683693
}
684694

695+
private class OperationAccess extends Access instanceof Operation {
696+
override Type getTypeArgument(TypeArgumentPosition apos, TypePath path) {
697+
// The syntax for operators does not allow type arguments.
698+
none()
699+
}
700+
701+
override AstNode getNodeAt(AccessPosition apos) {
702+
result = super.getOperand(0) and apos = TSelfAccessPosition()
703+
or
704+
result = super.getOperand(1) and apos = TPositionalAccessPosition(0, true)
705+
or
706+
result = this and apos = TReturnAccessPosition()
707+
}
708+
709+
override Type getInferredType(AccessPosition apos, TypePath path) {
710+
result = inferType(this.getNodeAt(apos), path)
711+
}
712+
713+
override Declaration getTarget() {
714+
result = inferMethodCallTarget(this) // mutual recursion; resolving method calls requires resolving types and vice versa
715+
}
716+
}
717+
685718
predicate accessDeclarationPositionMatch(AccessPosition apos, DeclarationPosition dpos) {
686719
apos.isSelf() and
687720
dpos.isSelf()
@@ -1061,6 +1094,26 @@ private module MethodCall {
10611094
pragma[nomagic]
10621095
override Type getTypeAt(TypePath path) { result = inferType(receiver, path) }
10631096
}
1097+
1098+
private class OperationMethodCall extends MethodCallImpl instanceof Operation {
1099+
TraitItemNode trait;
1100+
string methodName;
1101+
1102+
OperationMethodCall() { super.isOverloaded(trait, methodName) }
1103+
1104+
override string getMethodName() { result = methodName }
1105+
1106+
override int getArity() { result = this.(Operation).getNumberOfOperands() - 1 }
1107+
1108+
override Trait getTrait() { result = trait }
1109+
1110+
pragma[nomagic]
1111+
override Type getTypeAt(TypePath path) {
1112+
result = inferType(this.(BinaryExpr).getLhs(), path)
1113+
or
1114+
result = inferType(this.(PrefixExpr).getExpr(), path)
1115+
}
1116+
}
10641117
}
10651118

10661119
import MethodCall

0 commit comments

Comments
 (0)