JS: Add a missing class to needsDefNode

asgerf · asgerf · commit 19124c95e136 · 2025-11-27T10:28:49.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/ApiGraphs.qll b/javascript/ql/lib/semmle/javascript/ApiGraphs.qll
@@ -1539,6 +1539,7 @@ module API {
           succ = MkDef(rhs)
           or
           exists(DataFlow::ClassNode cls |
+            needsDefNode(cls) and
             cls.getAnInstanceReference().flowsTo(rhs) and
             succ = MkClassInstance(cls)
           )

Original file line number	Diff line number	Diff line change
`@@ -1539,6 +1539,7 @@ module API {`
`1539`	`1539`	`succ = MkDef(rhs)`
`1540`	`1540`	`or`
`1541`	`1541`	`exists(DataFlow::ClassNode cls \|`
	`1542`	`+ needsDefNode(cls) and`
`1542`	`1543`	`cls.getAnInstanceReference().flowsTo(rhs) and`
`1543`	`1544`	`succ = MkClassInstance(cls)`
`1544`	`1545`	`)`