Add Banned6 and improve @description metadata of A9-5-1

Author: jeongsoolee09

cpp/autosar/src/rules/A9-5-1/UnionsUsed.ql

@@ -1,7 +1,7 @@
 /**
  * @id cpp/autosar/unions-used
  * @name A9-5-1: Unions shall not be used
- * @description Unions shall not be used.  Tagged untions can be used if std::variant is not
+ * @description Unions shall not be used. Tagged unions can be used if 'std::variant' is not
  *              available.
  * @kind problem
  * @precision very-high

cpp/autosar/test/rules/A9-5-1/UnionsUsed.testref

@@ -0,0 +1 @@
+cpp/common/test/rules/unionkeywordused/UnionKeywordUsed.ql

cpp/common/src/codingstandards/cpp/exclusions/cpp/Banned6.qll

@@ -0,0 +1,26 @@
+//** THIS FILE IS AUTOGENERATED, DO NOT MODIFY DIRECTLY.  **/
+import cpp
+import RuleMetadata
+import codingstandards.cpp.exclusions.RuleMetadata
+
+newtype Banned6Query = TUnionKeywordUsedQuery()
+
+predicate isBanned6QueryMetadata(Query query, string queryId, string ruleId, string category) {
+  query =
+    // `Query` instance for the `unionKeywordUsed` query
+    Banned6Package::unionKeywordUsedQuery() and
+  queryId =
+    // `@id` for the `unionKeywordUsed` query
+    "cpp/misra/union-keyword-used" and
+  ruleId = "RULE-12-3-1" and
+  category = "required"
+}
+
+module Banned6Package {
+  Query unionKeywordUsedQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `unionKeywordUsed` query
+      TQueryCPP(TBanned6PackageQuery(TUnionKeywordUsedQuery()))
+  }
+}

cpp/common/src/codingstandards/cpp/exclusions/cpp/RuleMetadata.qll

@@ -5,6 +5,7 @@ import codingstandards.cpp.exclusions.RuleMetadata
 import Allocations
 import Banned1
 import Banned5
+import Banned6
 import Banned8
 import BannedAPIs
 import BannedFunctions
@@ -98,6 +99,7 @@ newtype TCPPQuery =
   TAllocationsPackageQuery(AllocationsQuery q) or
   TBanned1PackageQuery(Banned1Query q) or
   TBanned5PackageQuery(Banned5Query q) or
+  TBanned6PackageQuery(Banned6Query q) or
   TBanned8PackageQuery(Banned8Query q) or
   TBannedAPIsPackageQuery(BannedAPIsQuery q) or
   TBannedFunctionsPackageQuery(BannedFunctionsQuery q) or
@@ -191,6 +193,7 @@ predicate isQueryMetadata(Query query, string queryId, string ruleId, string cat
   isAllocationsQueryMetadata(query, queryId, ruleId, category) or
   isBanned1QueryMetadata(query, queryId, ruleId, category) or
   isBanned5QueryMetadata(query, queryId, ruleId, category) or
+  isBanned6QueryMetadata(query, queryId, ruleId, category) or
   isBanned8QueryMetadata(query, queryId, ruleId, category) or
   isBannedAPIsQueryMetadata(query, queryId, ruleId, category) or
   isBannedFunctionsQueryMetadata(query, queryId, ruleId, category) or

cpp/common/src/codingstandards/cpp/rules/unionkeywordused/UnionKeywordUsed.qll

@@ -0,0 +1,20 @@
+/**
+ * Provides a configurable module UnionKeywordUsed with a `problems` predicate
+ * for the following issue:
+ * Unions shall not be used. Tagged unions can be used if 'std::variant' is not
+ * available.
+ */
+
+import cpp
+import codingstandards.cpp.Customizations
+import codingstandards.cpp.Exclusions
+
+signature module UnionKeywordUsedConfigSig {
+  Query getQuery();
+}
+
+module UnionKeywordUsed<UnionKeywordUsedConfigSig Config> {
+  query predicate problems(Element e, string message) {
+    not isExcluded(e, Config::getQuery()) and message = "<replace with problem alert message for >"
+  }
+}

cpp/common/test/rules/unionkeywordused/UnionKeywordUsed.expected

@@ -0,0 +1 @@
+No expected results have yet been specified

cpp/common/test/rules/unionkeywordused/UnionKeywordUsed.ql

@@ -0,0 +1,8 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.unionkeywordused.UnionKeywordUsed
+
+module TestFileConfig implements UnionKeywordUsedConfigSig {
+  Query getQuery() { result instanceof TestQuery }
+}
+
+import UnionKeywordUsed<TestFileConfig>

cpp/common/test/rules/unionkeywordused/test.cpp

@@ -0,0 +1,24 @@
+/**
+ * @id cpp/misra/union-keyword-used
+ * @name RULE-12-3-1: The union keyword shall not be used
+ * @description Using unions should be avoided and 'std::variant' should be used as a type-safe
+ *              alternative.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-12-3-1
+ *       scope/single-translation-unit
+ *       correctness
+ *       external/misra/enforcement/decidable
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.cpp.misra
+import codingstandards.cpp.rules.unionkeywordused.UnionKeywordUsed
+
+module UnionKeywordUsedConfig implements UnionKeywordUsedConfigSig {
+  Query getQuery() { result = Banned6Package::unionKeywordUsedQuery() }
+}
+
+import UnionKeywordUsed<UnionKeywordUsedConfig>

cpp/misra/src/rules/RULE-12-3-1/UnionKeywordUsed.ql

@@ -0,0 +1 @@
+cpp/common/test/rules/unionkeywordused/UnionKeywordUsed.ql