Merge pull request #1016 from knewbury01/knewbury01/Linkage1

Add linkage1 package

Author: knewbury01

change_notes/2026-01-15-a3-1-4-extern-to-full.md

@@ -0,0 +1,2 @@
+- `A3-1-4` - `ExternalLinkageArrayWithoutExplicitSizeAutosar.ql`:
+   - `ExternalLinkageArrayWithoutExplicitSize.ql` has been renamed to `ExternalLinkageArrayWithoutExplicitSizeAutosar.ql` to reflect shared query implementation. Additionally the query previously only detected explicit uses of `extern` to determine external linkage, and now would catch other cases that are possible where it is external linkage and an array is declared without an explicit size.

cpp/autosar/src/rules/A3-1-4/ExternalLinkageArrayWithoutExplicitSize.ql

@@ -0,0 +1,26 @@
+/**
+ * @id cpp/autosar/external-linkage-array-without-explicit-size-autosar
+ * @name A3-1-4: When an array with external linkage is declared, its size shall be stated explicitly
+ * @description A developer can more safely access the elements of an array if the size of the array
+ *              can be explicitly determined.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity warning
+ * @tags external/autosar/id/a3-1-4
+ *       correctness
+ *       external/autosar/allocated-target/design
+ *       external/autosar/allocated-target/implementation
+ *       external/autosar/enforcement/automated
+ *       external/autosar/obligation/required
+ */
+
+import cpp
+import codingstandards.cpp.autosar
+import codingstandards.cpp.rules.externallinkagearraywithoutexplicitsize.ExternalLinkageArrayWithoutExplicitSize
+
+class ExternalLinkageArrayWithoutExplicitSizeAutosarQuery extends ExternalLinkageArrayWithoutExplicitSizeSharedQuery
+{
+  ExternalLinkageArrayWithoutExplicitSizeAutosarQuery() {
+    this = ScopePackage::externalLinkageArrayWithoutExplicitSizeAutosarQuery()
+  }
+}

cpp/autosar/src/rules/A3-1-4/ExternalLinkageArrayWithoutExplicitSizeAutosar.ql

@@ -17,25 +17,11 @@
 
 import cpp
 import codingstandards.cpp.autosar
-import codingstandards.cpp.Linkage
-import codingstandards.cpp.EncapsulatingFunctions
+import codingstandards.cpp.rules.externallinkagenotdeclaredinheaderfile.ExternalLinkageNotDeclaredInHeaderFile
 
-from DeclarationEntry de, string kind
-where
-  not isExcluded(de, IncludesPackage::externalLinkageNotDeclaredInHeaderFileQuery()) and
-  hasExternalLinkage(de.getDeclaration()) and
-  // Exclude subobjects such as struct members or member functions
-  de.getDeclaration().isTopLevel() and
-  // The declaration with external linkage does not have a declaration in a header file
-  exists(Compilation c | de.getFile() = c.getAFileCompiled()) and
-  not exists(DeclarationEntry otherDe |
-    de.getDeclaration() = otherDe.getDeclaration() and
-    not de = otherDe and
-    not otherDe.isDefinition()
-  |
-    otherDe.getFile() instanceof HeaderFile
-  ) and
-  // Main functions are an exception to the rule
-  not de.getDeclaration() instanceof MainFunction and
-  if de.getDeclaration() instanceof Function then kind = "function" else kind = "object"
-select de, "Externally linked " + kind + " '" + de.getName() + "' not declared in header file."
+class ExternalLinkageNotDeclaredInHeaderFileQuery extends ExternalLinkageNotDeclaredInHeaderFileSharedQuery
+{
+  ExternalLinkageNotDeclaredInHeaderFileQuery() {
+    this = IncludesPackage::externalLinkageNotDeclaredInHeaderFileQuery()
+  }
+}

cpp/autosar/src/rules/A3-3-1/ExternalLinkageNotDeclaredInHeaderFile.ql

@@ -0,0 +1 @@
+cpp/common/test/rules/externallinkagearraywithoutexplicitsize/ExternalLinkageArrayWithoutExplicitSize.ql

cpp/autosar/test/rules/A3-1-4/ExternalLinkageArrayWithoutExplicitSize.expected

@@ -0,0 +1 @@
+cpp/common/test/rules/externallinkagenotdeclaredinheaderfile/ExternalLinkageNotDeclaredInHeaderFile.ql