Skip to content

Commit a4ca148

Browse files
committed
Apply a few other review comments
1 parent c6997fd commit a4ca148

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

cpp/misra/src/rules/RULE-13-3-3/DeclarationsOfAFunctionSameParameterName.ql

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import codingstandards.cpp.misra
1919
import codingstandards.cpp.types.Compatible
2020

2121
predicate parameterNamesUnmatchedOverrides(FunctionDeclarationEntry f1, FunctionDeclarationEntry f2) {
22-
pragma[only_bind_into](f1).getFunction().(MemberFunction).getAnOverridingFunction*() =
22+
pragma[only_bind_into](f1).getFunction().(MemberFunction).getAnOverridingFunction+() =
2323
pragma[only_bind_into](f2).getFunction() and
2424
exists(string p1Name, string p2Name, int i |
2525
p1Name = f1.getParameterDeclarationEntry(i).getName() and
@@ -42,6 +42,5 @@ where
4242
parameterNamesUnmatchedOverrides(f1, f2) and
4343
case = "override"
4444
)
45-
select f1,
46-
"The parameter names of " + case + " of $@ do" + " not use the same names as declaration $@", f1,
47-
f1.getName(), f2, f2.getName()
45+
select f1, "The parameter names of " + case + " of $@ do not use the same names as declaration $@",
46+
f1, f1.getName(), f2, f2.getName()

0 commit comments

Comments
 (0)