Add query files for Banned4

Author: jeongsoolee09

cpp/common/src/codingstandards/cpp/exclusions/cpp/Banned4.qll

@@ -0,0 +1,26 @@
+//** THIS FILE IS AUTOGENERATED, DO NOT MODIFY DIRECTLY.  **/
+import cpp
+import RuleMetadata
+import codingstandards.cpp.exclusions.RuleMetadata
+
+newtype Banned4Query = TUnnamedNamespacesInHeaderFilesQuery()
+
+predicate isBanned4QueryMetadata(Query query, string queryId, string ruleId, string category) {
+  query =
+    // `Query` instance for the `unnamedNamespacesInHeaderFiles` query
+    Banned4Package::unnamedNamespacesInHeaderFilesQuery() and
+  queryId =
+    // `@id` for the `unnamedNamespacesInHeaderFiles` query
+    "cpp/misra/unnamed-namespaces-in-header-files" and
+  ruleId = "RULE-10-3-1" and
+  category = "advisory"
+}
+
+module Banned4Package {
+  Query unnamedNamespacesInHeaderFilesQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `unnamedNamespacesInHeaderFiles` query
+      TQueryCPP(TBanned4PackageQuery(TUnnamedNamespacesInHeaderFilesQuery()))
+  }
+}

cpp/common/src/codingstandards/cpp/exclusions/cpp/RuleMetadata.qll

@@ -6,6 +6,7 @@ import Allocations
 import Banned1
 import Banned2
 import Banned3
+import Banned4
 import BannedAPIs
 import BannedFunctions
 import BannedLibraries
@@ -96,6 +97,7 @@ newtype TCPPQuery =
   TBanned1PackageQuery(Banned1Query q) or
   TBanned2PackageQuery(Banned2Query q) or
   TBanned3PackageQuery(Banned3Query q) or
+  TBanned4PackageQuery(Banned4Query q) or
   TBannedAPIsPackageQuery(BannedAPIsQuery q) or
   TBannedFunctionsPackageQuery(BannedFunctionsQuery q) or
   TBannedLibrariesPackageQuery(BannedLibrariesQuery q) or
@@ -186,6 +188,7 @@ predicate isQueryMetadata(Query query, string queryId, string ruleId, string cat
   isBanned1QueryMetadata(query, queryId, ruleId, category) or
   isBanned2QueryMetadata(query, queryId, ruleId, category) or
   isBanned3QueryMetadata(query, queryId, ruleId, category) or
+  isBanned4QueryMetadata(query, queryId, ruleId, category) or
   isBannedAPIsQueryMetadata(query, queryId, ruleId, category) or
   isBannedFunctionsQueryMetadata(query, queryId, ruleId, category) or
   isBannedLibrariesQueryMetadata(query, queryId, ruleId, category) or

cpp/misra/src/rules/RULE-10-3-1/UnnamedNamespacesInHeaderFiles.ql

@@ -0,0 +1,25 @@
+/**
+ * @id cpp/misra/unnamed-namespaces-in-header-files
+ * @name RULE-10-3-1: There should be no unnamed namespaces in header files
+ * @description Anonymous namespaces in header files create separate entities in each translation
+ *              unit, which may not be consistent with developer expectations.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-10-3-1
+ *       scope/single-translation-unit
+ *       correctness
+ *       external/misra/enforcement/decidable
+ *       external/misra/obligation/advisory
+ */
+
+import cpp
+import codingstandards.cpp.misra
+
+from NamespaceDeclarationEntry namespaceDeclarationEntry, HeaderFile headerFile
+where
+  not isExcluded(namespaceDeclarationEntry, Banned4Package::unnamedNamespacesInHeaderFilesQuery()) and
+  namespaceDeclarationEntry.getNamespace().isAnonymous() and
+  headerFile = namespaceDeclarationEntry.getFile()
+select namespaceDeclarationEntry, "Anonymous namespace declared in header file $@.", headerFile,
+  headerFile.getBaseName()

cpp/misra/test/rules/RULE-10-3-1/UnnamedNamespacesInHeaderFiles.expected

@@ -0,0 +1,3 @@
+| test.hpp:5:1:5:9 | (unnamed namespace) | Anonymous namespace declared in header file $@. | test.hpp:0:0:0:0 | test.hpp | test.hpp |
+| test.hpp:32:1:32:9 | Outer::(unnamed namespace) | Anonymous namespace declared in header file $@. | test.hpp:0:0:0:0 | test.hpp | test.hpp |
+| test.hpp:41:1:41:9 | (unnamed namespace) | Anonymous namespace declared in header file $@. | test.hpp:0:0:0:0 | test.hpp | test.hpp |

cpp/misra/test/rules/RULE-10-3-1/UnnamedNamespacesInHeaderFiles.qlref

@@ -0,0 +1 @@
+rules/RULE-10-3-1/UnnamedNamespacesInHeaderFiles.ql

cpp/misra/test/rules/RULE-10-3-1/test.hpp

@@ -0,0 +1,44 @@
+#include <cstdint>
+
+/* ========== 1. Non-compliant: anonymous namespace in header ========== */
+
+namespace { // NON_COMPLIANT: anonymous namespace in header file
+inline std::int32_t x = 0;
+
+void helper() {}
+
+class InternalClass {};
+} // namespace
+
+/* ========== 2. Compliant: named namespace in header ========== */
+
+namespace MyNamespace { // COMPLIANT: named namespace
+inline std::int32_t y = 0;
+
+void publicHelper();
+
+class PublicClass {};
+} // namespace MyNamespace
+
+/* ========== 3. Compliant: no namespace ========== */
+
+inline std::int32_t z = 0; // COMPLIANT: no anonymous namespace
+
+void declaredFunction();
+
+/* ========== 4. Non-compliant: nested anonymous namespace ========== */
+
+namespace Outer {
+namespace { // NON_COMPLIANT: anonymous namespace in header file
+inline std::int32_t nested = 0;
+}
+} // namespace Outer
+
+/* ========== 5. Non-compliant: anonymous namespace with extern "C" ==========
+ */
+
+extern "C" {
+namespace { // NON_COMPLIANT: anonymous namespace in header file
+inline std::int32_t cStyleVar = 0;
+}
+}

cpp/misra/test/rules/RULE-10-3-1/test1.cpp

@@ -0,0 +1,21 @@
+#include "test.hpp"
+
+/*
+ * This file demonstrates that anonymous namespace variables
+ * in headers create translation-unit-local copies.
+ */
+
+void setValues() {
+  x = 42;              // Sets file1.cpp's copy of x
+  MyNamespace::y = 42; // Sets the shared y
+  z = 42;              // Sets the shared z
+  Outer::nested = 42;  // Sets file1.cpp's copy of nested
+}
+
+std::int32_t getX_File1() {
+  return x; // Returns file1.cpp's copy of x
+}
+
+std::int32_t getNested_File1() {
+  return Outer::nested; // Returns file1.cpp's copy of nested
+}

cpp/misra/test/rules/RULE-10-3-1/test2.cpp

@@ -0,0 +1,50 @@
+#include "test.hpp"
+#include <cassert>
+
+/*
+ * This file demonstrates the mismatch in expectations.
+ * After calling setValues() from file1.cpp:
+ * - x is 0 here (different copy)
+ * - MyNamespace::y is 42 (shared)
+ * - z is 42 (shared)
+ * - Outer::nested is 0 here (different copy)
+ */
+
+extern void setValues();
+extern std::int32_t getX_File1();
+extern std::int32_t getNested_File1();
+
+void checkMismatch() {
+  setValues();
+
+  /*
+   * These demonstrate the MISMATCH - anonymous namespace creates separate
+   * copies.
+   */
+  assert(x == 0);             // file2.cpp's x was never set!
+  assert(getX_File1() == 42); // file1.cpp's x was set
+
+  assert(Outer::nested == 0);      // file2.cpp's nested was never set!
+  assert(getNested_File1() == 42); // file1.cpp's nested was set
+
+  /* These demonstrate EXPECTED behavior - named namespace and global are shared
+   */
+  assert(MyNamespace::y == 42); // Shared across TUs
+  assert(z == 42);              // Shared across TUs
+}
+
+/* ========== 6. Compliant: anonymous namespace in .cpp file ========== */
+
+namespace { // COMPLIANT: anonymous namespace in source file is fine
+std::int32_t localVar = 0;
+
+void localHelper() {
+  localVar = 100; // Only visible in this TU, as expected
+}
+} // namespace
+
+int main() {
+  checkMismatch();
+  localHelper();
+  return 0;
+}

rule_packages/cpp/Banned4.json

@@ -0,0 +1,25 @@
+{
+  "MISRA-C++-2023": {
+    "RULE-10-3-1": {
+      "properties": {
+        "enforcement": "decidable",
+        "obligation": "advisory"
+      },
+      "queries": [
+        {
+          "description": "Anonymous namespaces in header files create separate entities in each translation unit, which may not be consistent with developer expectations.",
+          "kind": "problem",
+          "name": "There should be no unnamed namespaces in header files",
+          "precision": "very-high",
+          "severity": "error",
+          "short_name": "UnnamedNamespacesInHeaderFiles",
+          "tags": [
+            "scope/single-translation-unit",
+            "correctness"
+          ]
+        }
+      ],
+      "title": "There should be no unnamed namespaces in header files"
+    }
+  }
+}