Merge remote-tracking branch 'origin/michaelrfairhurst/package-undefined-behavior' into michaelrfairhurst/package-undefined-behavior-cast-enum-out-of-range

Author: MichaelRFairhurst

change_notes/2026-03-13-make-string-literal-query-shared.md

@@ -0,0 +1,2 @@
+ - `A2-13-4` - `StringLiteralsAssignedToNonConstantPointers.ql`:
+   - Refactored query logic into a shared module (`StringLiteralsAssignedToNonConstantPointersShared`) to enable reuse by MISRA C++ `RULE-4-1-3`. The query logic is unchanged. No visible changes to results or performance are expected.

change_notes/2026-03-13-share-deallocation-type-mismatch-query.md

@@ -0,0 +1,2 @@
+ - `MEM51-CPP` - `ProperlyDeallocateDynamicallyAllocatedResources.ql`:
+   - Refactored query logic into a shared library (`ProperlyDeallocateDynamicallyAllocatedResourcesShared.qll`) to enable reuse by MISRA C++ `RULE-4-1-3`. The query logic is unchanged and no visible changes to results or performance are expected.

change_notes/2026-03-16-share-divisor-equal-to-zero-query.md

@@ -0,0 +1,2 @@
+ - `A5-6-1` - `DivisorEqualToZero.ql`:
+   - Refactored query logic into a shared library (`DivisorEqualToZeroShared.qll`) to enable reuse by MISRA C++ `RULE-4-1-3`. The query logic is unchanged and no visible changes to results or performance are expected.

cpp/autosar/src/rules/A2-13-4/StringLiteralsAssignedToNonConstantPointers.ql

@@ -17,11 +17,12 @@
 
 import cpp
 import codingstandards.cpp.autosar
+import codingstandards.cpp.rules.stringliteralsassignedtononconstantpointersshared.StringLiteralsAssignedToNonConstantPointersShared
 
-from ArrayToPointerConversion apc
-where
-  not isExcluded(apc, StringsPackage::stringLiteralsAssignedToNonConstantPointersQuery()) and
-  apc.getExpr() instanceof StringLiteral and
-  apc.getExpr().getUnderlyingType().(ArrayType).getBaseType().isConst() and
-  not apc.getFullyConverted().getType().getUnderlyingType().(PointerType).getBaseType().isConst()
-select apc, "String literal assigned to non-const pointer."
+module StringLiteralsAssignedToNonConstantPointersConfig implements
+  StringLiteralsAssignedToNonConstantPointersSharedConfigSig
+{
+  Query getQuery() { result = StringsPackage::stringLiteralsAssignedToNonConstantPointersQuery() }
+}
+
+import StringLiteralsAssignedToNonConstantPointersShared<StringLiteralsAssignedToNonConstantPointersConfig>

cpp/autosar/src/rules/A5-6-1/DivisorEqualToZero.ql

@@ -15,10 +15,10 @@
 
 import cpp
 import codingstandards.cpp.autosar
+import codingstandards.cpp.rules.divisorequaltozeroshared.DivisorEqualToZeroShared
 
-from BinaryArithmeticOperation bao
-where
-  not isExcluded(bao, ExpressionsPackage::divisorEqualToZeroQuery()) and
-  (bao instanceof DivExpr or bao instanceof RemExpr) and
-  bao.getRightOperand().getValue().toFloat() = 0 // `toFloat()` holds for both integer and float literals.
-select bao, "Divisor is zero."
+module DivisorEqualToZeroConfig implements DivisorEqualToZeroSharedConfigSig {
+  Query getQuery() { result = ExpressionsPackage::divisorEqualToZeroQuery() }
+}
+
+import DivisorEqualToZeroShared<DivisorEqualToZeroConfig>

cpp/autosar/test/rules/A2-13-4/StringLiteralsAssignedToNonConstantPointers.qlref

@@ -0,0 +1 @@
+cpp/common/test/rules/stringliteralsassignedtononconstantpointersshared/StringLiteralsAssignedToNonConstantPointersShared.ql

cpp/autosar/test/rules/A2-13-4/StringLiteralsAssignedToNonConstantPointers.testref

@@ -0,0 +1 @@
+cpp/common/test/rules/divisorequaltozeroshared/DivisorEqualToZeroShared.ql

cpp/autosar/test/rules/A5-6-1/DivisorEqualToZero.qlref

@@ -19,20 +19,14 @@
 
 import cpp
 import codingstandards.cpp.cert
-import codingstandards.cpp.Allocations
+import codingstandards.cpp.rules.properlydeallocatedynamicallyallocatedresourcesshared.ProperlyDeallocateDynamicallyAllocatedResourcesShared
 
-predicate matching(string allocKind, string deleteKind) {
-  allocKind = "new" and deleteKind = "delete"
-  or
-  allocKind = "new[]" and deleteKind = "delete[]"
-  or
-  allocKind = "malloc" and deleteKind = "free"
+module ProperlyDeallocateDynamicallyAllocatedResourcesConfig implements
+  ProperlyDeallocateDynamicallyAllocatedResourcesSharedConfigSig
+{
+  Query getQuery() {
+    result = AllocationsPackage::properlyDeallocateDynamicallyAllocatedResourcesQuery()
+  }
 }
 
-from Expr alloc, Expr free, Expr freed, string allocKind, string deleteKind
-where
-  not isExcluded(freed, AllocationsPackage::properlyDeallocateDynamicallyAllocatedResourcesQuery()) and
-  allocReaches(freed, alloc, allocKind) and
-  freeExprOrIndirect(free, freed, deleteKind) and
-  not matching(allocKind, deleteKind)
-select free, "Memory allocated with $@ but deleted with " + deleteKind + ".", alloc, allocKind
+import ProperlyDeallocateDynamicallyAllocatedResourcesShared<ProperlyDeallocateDynamicallyAllocatedResourcesConfig>