Skip to content

Commit cfda2ef

Browse files
committed
chore: use shorter columns prop name
1 parent 9a4c403 commit cfda2ef

52 files changed

Lines changed: 257 additions & 264 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

with-i18n-translate/src/examples/slickgrid/Example01.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ const Example1: React.FC = () => {
1515
const [dataset2] = useState<any[]>(mockData(NB_ITEMS));
1616

1717
/* Define grid Options and Columns */
18-
const columnDefinitions1: Column[] = [
18+
const columns1: Column[] = [
1919
{ id: 'title', name: 'Title', field: 'title', sortable: true, minWidth: 100 },
2020
{ id: 'duration', name: 'Duration (days)', field: 'duration', sortable: true, minWidth: 100 },
2121
{ id: '%', name: '% Complete', field: 'percentComplete', sortable: true, minWidth: 100 },
2222
{ id: 'start', name: 'Start', field: 'start', formatter: Formatters.dateIso },
2323
{ id: 'finish', name: 'Finish', field: 'finish', formatter: Formatters.dateIso },
2424
{ id: 'effort-driven', name: 'Effort Driven', field: 'effortDriven', sortable: true, minWidth: 100 },
2525
];
26-
const columnDefinitions2: Column[] = [...columnDefinitions1];
26+
const columns2: Column[] = [...columns1];
2727

2828
const gridOptions1: GridOption = {
2929
darkMode: defaultBrowserDarkMode,
@@ -81,7 +81,7 @@ const Example1: React.FC = () => {
8181

8282
function resetGrid1() {
8383
// const cols = reactGrid1.slickGrid?.getColumns() || [];
84-
const cols = columnDefinitions1.slice();
84+
const cols = columns1.slice();
8585
cols.forEach((c) => (c.hidden = false));
8686
reactGrid1?.slickGrid?.setColumns(cols);
8787
reactGrid1?.slickGrid?.autosizeColumns();
@@ -144,7 +144,7 @@ const Example1: React.FC = () => {
144144
<div className="grid-container1">
145145
<SlickgridReact
146146
gridId="grid1-1"
147-
columns={columnDefinitions1}
147+
columns={columns1}
148148
options={gridOptions1!}
149149
dataset={dataset1}
150150
onReactGridCreated={($event) => reactGrid1Ready($event.detail)}
@@ -156,7 +156,7 @@ const Example1: React.FC = () => {
156156
<h3>
157157
Grid 2 <small>(with local Pagination)</small>
158158
</h3>
159-
<SlickgridReact gridId="grid1-2" columns={columnDefinitions2} options={gridOptions2!} dataset={dataset2} />
159+
<SlickgridReact gridId="grid1-2" columns={columns2} options={gridOptions2!} dataset={dataset2} />
160160
</div>
161161
);
162162
};

with-i18n-translate/src/examples/slickgrid/Example02.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const Example2: React.FC = () => {
3838
const [hideSubTitle, setHideSubTitle] = useState(false);
3939

4040
// the columns field property is type-safe, try to add a different string not representing one of DataItems properties
41-
const columnDefinitions: Column[] = [
41+
const columns: Column[] = [
4242
{ id: 'title', name: 'Title', field: 'title', sortable: true, width: 70 },
4343
{
4444
id: 'phone',
@@ -280,7 +280,7 @@ const Example2: React.FC = () => {
280280

281281
<SlickgridReact
282282
gridId="grid2"
283-
columns={columnDefinitions}
283+
columns={columns}
284284
options={gridOptions}
285285
dataset={dataset}
286286
onReactGridCreated={($event) => reactGridReady($event.detail)}

with-i18n-translate/src/examples/slickgrid/Example03.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ const Example3: React.FC = () => {
6767
const [reactGrid, setReactGrid] = useState<SlickgridReactInstance>();
6868
const [hideSubTitle, setHideSubTitle] = useState(false);
6969

70-
const [columnDefinitions, setColumnDefinitions] = useState<Column[]>([
70+
const [columns, setColumns] = useState<Column[]>([
7171
{
7272
id: 'edit',
7373
field: 'id',
@@ -448,7 +448,7 @@ const Example3: React.FC = () => {
448448
// wrap into a timer to simulate a backend async call
449449
setTimeout(() => {
450450
// at any time, we can poke the 'collection' property and modify it
451-
const requisiteColumnDef = columnDefinitions?.find((column: Column) => column.id === 'prerequisites');
451+
const requisiteColumnDef = columns?.find((column: Column) => column.id === 'prerequisites');
452452
if (requisiteColumnDef) {
453453
const collectionEditor = requisiteColumnDef.editor!.collection;
454454
const collectionFilter = requisiteColumnDef.filter!.collection;
@@ -485,7 +485,7 @@ const Example3: React.FC = () => {
485485

486486
/** Delete last inserted row */
487487
function deleteItem() {
488-
const requisiteColumnDef = columnDefinitions?.find((column: Column) => column.id === 'prerequisites');
488+
const requisiteColumnDef = columns?.find((column: Column) => column.id === 'prerequisites');
489489
if (requisiteColumnDef) {
490490
const collectionEditor = requisiteColumnDef.editor!.collection;
491491
const collectionFilter = requisiteColumnDef.filter!.collection;
@@ -592,26 +592,26 @@ const Example3: React.FC = () => {
592592

593593
// you can dynamically add your column to your column definitions
594594
// and then use the spread operator [...cols] OR slice to force React to review the changes
595-
setColumnDefinitions([...columnDefinitions!, newCol]);
595+
setColumns([...columns!, newCol]);
596596

597597
// NOTE if you use an Extensions (Checkbox Selector, Row Detail, ...) that modifies the column definitions in any way
598598
// you MUST use 'getAllColumnDefinitions()' from the GridService, using this will be ALL columns including the 1st column that is created internally
599599
// for example if you use the Checkbox Selector (row selection), you MUST use the code below
600600
/*
601601
const allColumns = reactGrid.gridService.getAllColumnDefinitions();
602602
allColumns.push(newCol);
603-
columnDefinitions = [...allColumns]; // (or use slice) reassign to column definitions for React to do dirty checking
603+
columns = [...allColumns]; // (or use slice) reassign to column definitions for React to do dirty checking
604604
*/
605605
}
606606

607607
function dynamicallyRemoveLastColumn() {
608-
columnDefinitions.pop();
609-
setColumnDefinitions(columnDefinitions.slice());
608+
columns.pop();
609+
setColumns(columns.slice());
610610

611611
/*
612612
// remove your column the full set of columns
613613
allOriginalColumns.pop();
614-
columnDefinitions = allOriginalColumns.slice();
614+
columns = allOriginalColumns.slice();
615615
*/
616616
}
617617

@@ -785,7 +785,7 @@ const Example3: React.FC = () => {
785785
<div className="col-sm-12">
786786
<SlickgridReact
787787
gridId="grid3"
788-
columns={columnDefinitions}
788+
columns={columns}
789789
options={gridOptions}
790790
dataset={dataset}
791791
onReactGridCreated={(e) => {

with-i18n-translate/src/examples/slickgrid/Example04.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const Example4: React.FC = () => {
2828
saveCurrentGridState();
2929
}, []);
3030

31-
const columnDefinitions: Column[] = [
31+
const columns: Column[] = [
3232
{
3333
id: 'title',
3434
name: 'Title',
@@ -438,7 +438,7 @@ const Example4: React.FC = () => {
438438

439439
<SlickgridReact
440440
gridId="grid4"
441-
columns={columnDefinitions}
441+
columns={columns}
442442
options={gridOptions}
443443
dataset={dataset}
444444
onGridStateChanged={($event) => gridStateChanged($event.detail)}

with-i18n-translate/src/examples/slickgrid/Example05.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ interface Status {
2424

2525
const Example5: React.FC = () => {
2626
const [gridOptions, setGridOptions] = useState<GridOption | undefined>(undefined);
27-
const [columnDefinitions, setColumnDefinitions] = useState<Column[]>([]);
27+
const [columns, setColumns] = useState<Column[]>([]);
2828
const [dataset, setDataset] = useState<any[]>([]);
2929
const [paginationOptions, setPaginationOptions] = useState<Pagination | undefined>(undefined);
3030
const [errorStatus, setErrorStatus] = useState<string>('');
@@ -122,7 +122,7 @@ const Example5: React.FC = () => {
122122
};
123123
}
124124

125-
function getColumnDefinitions(): Column[] {
125+
function getColumns(): Column[] {
126126
return [
127127
{
128128
id: 'name',
@@ -163,11 +163,11 @@ const Example5: React.FC = () => {
163163
}
164164

165165
function defineGrid() {
166-
const columnDefinitions = getColumnDefinitions();
166+
const columns = getColumns();
167167
const gridOptions = getGridDefinition();
168168

169169
gridOptionsRef.current = gridOptions;
170-
setColumnDefinitions(columnDefinitions);
170+
setColumns(columns);
171171
setGridOptions(gridOptions);
172172
}
173173

@@ -713,7 +713,7 @@ const Example5: React.FC = () => {
713713

714714
<SlickgridReact
715715
gridId="grid5"
716-
columns={columnDefinitions}
716+
columns={columns}
717717
options={gridOptions}
718718
dataset={dataset}
719719
paginationOptions={paginationOptions}

with-i18n-translate/src/examples/slickgrid/Example06.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const FAKE_SERVER_DELAY = 250;
3333
const Example6: React.FC = () => {
3434
const defaultLang = 'en';
3535
const [gridOptions, setGridOptions] = useState<GridOption | undefined>(undefined);
36-
const [columnDefinitions, setColumnDefinitions] = useState<Column[]>([]);
36+
const [columns, setColumns] = useState<Column[]>([]);
3737
const [dataset] = useState<any[]>([]);
3838
const [metrics, setMetrics] = useState<Metrics | undefined>(undefined);
3939
const [processing, setProcessing] = useState<boolean>(false);
@@ -176,10 +176,10 @@ const Example6: React.FC = () => {
176176
}
177177

178178
function defineGrid() {
179-
const columnDefinitions = getColumnsDefinition();
179+
const columns = getColumnsDefinition();
180180
const gridOptions = getGridOptions();
181181

182-
setColumnDefinitions(columnDefinitions);
182+
setColumns(columns);
183183
setGridOptions(gridOptions);
184184
}
185185

@@ -620,7 +620,7 @@ const Example6: React.FC = () => {
620620

621621
<SlickgridReact
622622
gridId="grid6"
623-
columns={columnDefinitions}
623+
columns={columns}
624624
options={gridOptions}
625625
dataset={dataset}
626626
onReactGridCreated={($event) => reactGridReady($event.detail)}

with-i18n-translate/src/examples/slickgrid/Example07.tsx

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import './example07.scss';
55
const Example7: React.FC = () => {
66
const [gridOptions1, setGridOptions1] = useState<GridOption | undefined>(undefined);
77
const [gridOptions2, setGridOptions2] = useState<GridOption | undefined>(undefined);
8-
const [columnDefinitions1, setColumnDefinitions1] = useState<Column[]>([]);
9-
const [columnDefinitions2, setColumnDefinitions2] = useState<Column[]>([]);
8+
const [columns1, setColumns1] = useState<Column[]>([]);
9+
const [columns2, setColumns2] = useState<Column[]>([]);
1010
const [dataset1, setDataset1] = useState<any[]>([]);
1111
const [dataset2, setDataset2] = useState<any[]>([]);
1212
const [hideSubTitle, setHideSubTitle] = useState(false);
@@ -65,13 +65,13 @@ const Example7: React.FC = () => {
6565
},
6666
});
6767

68-
const columnDefinitions1 = createColumnDefinitions(1);
69-
const columnDefinitions2 = createColumnDefinitions(2);
70-
setColumnDefinitions1(columnDefinitions1);
71-
setColumnDefinitions2(columnDefinitions2);
68+
const columns1 = createColumns(1);
69+
const columns2 = createColumns(2);
70+
setColumns1(columns1);
71+
setColumns2(columns2);
7272

73-
setDataset1(loadData(200, columnDefinitions1));
74-
setDataset2(loadData(200, columnDefinitions2));
73+
setDataset1(loadData(200, columns1));
74+
setDataset2(loadData(200, columns2));
7575
}
7676

7777
function handleOnCommand(_e: SlickEventData, args: any, gridNo: 1 | 2) {
@@ -105,12 +105,12 @@ const Example7: React.FC = () => {
105105
}
106106
}
107107

108-
function createColumnDefinitions(gridNo: number) {
108+
function createColumns(gridNo: number) {
109109
// Set up some test columns.
110-
const columnDefinitions: any[] = [];
110+
const columns: any[] = [];
111111

112112
for (let i = 0; i < 10; i++) {
113-
columnDefinitions.push({
113+
columns.push({
114114
id: i,
115115
name: 'Column ' + String.fromCharCode('A'.charCodeAt(0) + i),
116116
field: i + '',
@@ -151,8 +151,8 @@ const Example7: React.FC = () => {
151151
}
152152

153153
// Set multiple buttons on the first column to demonstrate overflow.
154-
columnDefinitions[0].name = 'Resize me!';
155-
columnDefinitions[0].header = {
154+
columns[0].name = 'Resize me!';
155+
columns[0].header = {
156156
buttons: [
157157
{
158158
cssClass: 'mdi mdi-message-text',
@@ -183,12 +183,12 @@ const Example7: React.FC = () => {
183183

184184
// when floating to left, you might want to inverse the icon orders
185185
if (gridNo === 2) {
186-
columnDefinitions[0].header?.buttons?.reverse();
186+
columns[0].header?.buttons?.reverse();
187187
}
188188

189189
// Set a button on the second column to demonstrate hover.
190-
columnDefinitions[1].name = 'Hover me!';
191-
columnDefinitions[1].header = {
190+
columns[1].name = 'Hover me!';
191+
columns[1].header = {
192192
buttons: [
193193
{
194194
cssClass: 'mdi mdi-help-circle',
@@ -201,17 +201,17 @@ const Example7: React.FC = () => {
201201
],
202202
};
203203

204-
return columnDefinitions;
204+
return columns;
205205
}
206206

207-
function loadData(count: number, columnDefinitions: Column[]) {
207+
function loadData(count: number, columns: Column[]) {
208208
// mock a dataset
209209
const mockDataset: any[] = [];
210210

211211
for (let i = 0; i < count; i++) {
212212
const d: any = (mockDataset[i] = {});
213213
d['id'] = i;
214-
for (let j = 0; j < columnDefinitions.length; j++) {
214+
for (let j = 0; j < columns.length; j++) {
215215
d[j] = Math.round(Math.random() * 10) - 5;
216216
}
217217
}
@@ -270,7 +270,7 @@ const Example7: React.FC = () => {
270270
<h5>Grid 1</h5>
271271
<SlickgridReact
272272
gridId="grid7-1"
273-
columns={columnDefinitions1}
273+
columns={columns1}
274274
options={gridOptions1}
275275
dataset={dataset1}
276276
onReactGridCreated={($event) => reactGrid1Ready($event.detail)}
@@ -283,7 +283,7 @@ const Example7: React.FC = () => {
283283
</h5>
284284
<SlickgridReact
285285
gridId="grid7-2"
286-
columns={columnDefinitions2}
286+
columns={columns2}
287287
options={gridOptions2}
288288
dataset={dataset2}
289289
onReactGridCreated={($event) => reactGrid2Ready($event.detail)}

with-i18n-translate/src/examples/slickgrid/Example08.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import './example08.scss'; // provide custom CSS/SASS styling
66

77
const Example8: React.FC = () => {
88
const defaultLang = 'en';
9-
const [columnDefinitions, setColumnDefinitions] = useState<Column[]>([]);
9+
const [columns, setColumns] = useState<Column[]>([]);
1010
const [dataset, setDataset] = useState<any[]>([]);
1111
const [gridOptions, setGridOptions] = useState<GridOption | undefined>(undefined);
1212
const [selectedLanguage, setSelectedLanguage] = useState<string>(defaultLang);
@@ -19,8 +19,8 @@ const Example8: React.FC = () => {
1919
getData();
2020
}, []);
2121

22-
function getColumnDefinitions(): Column[] {
23-
const columnDefinitions: Column[] = [
22+
function getColumns(): Column[] {
23+
const columns: Column[] = [
2424
{ id: 'title', name: 'Title', field: 'title', nameKey: 'TITLE' },
2525
{ id: 'duration', name: 'Duration', field: 'duration', nameKey: 'DURATION', sortable: true },
2626
{ id: 'percentComplete', name: '% Complete', field: 'percentComplete', nameKey: 'PERCENT_COMPLETE', sortable: true },
@@ -29,7 +29,7 @@ const Example8: React.FC = () => {
2929
{ id: 'completed', name: 'Completed', field: 'completed', nameKey: 'COMPLETED', formatter: Formatters.checkmarkMaterial },
3030
];
3131

32-
columnDefinitions.forEach((columnDef) => {
32+
columns.forEach((columnDef) => {
3333
columnDef.header = {
3434
menu: {
3535
commandItems: [
@@ -104,7 +104,7 @@ const Example8: React.FC = () => {
104104
},
105105
};
106106
});
107-
return columnDefinitions;
107+
return columns;
108108
}
109109

110110
function getGridOptions(): GridOption {
@@ -141,9 +141,9 @@ const Example8: React.FC = () => {
141141

142142
function defineGrid() {
143143
const gridOptions = getGridOptions();
144-
const columnDefinitions = getColumnDefinitions();
144+
const columns = getColumns();
145145

146-
setColumnDefinitions(columnDefinitions);
146+
setColumns(columns);
147147
setGridOptions(gridOptions);
148148
}
149149

@@ -230,7 +230,7 @@ const Example8: React.FC = () => {
230230
<span style={{ fontStyle: 'italic' }} data-test="selected-locale">
231231
{selectedLanguage + '.json'}
232232
</span>
233-
<SlickgridReact gridId="grid8" columns={columnDefinitions} options={gridOptions} dataset={dataset} />
233+
<SlickgridReact gridId="grid8" columns={columns} options={gridOptions} dataset={dataset} />
234234
</div>
235235
);
236236
};

0 commit comments

Comments
 (0)