Skip to content

Commit 5e3021b

Browse files
author
Matthieu Devlin
committed
fix: fix existing tests which failed because client is now instrumented (and used in tests)
1 parent 7c0945d commit 5e3021b

1 file changed

Lines changed: 13 additions & 8 deletions

File tree

tests/integrations/aiohttp/test_aiohttp.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ async def hello(request):
5454
"Accept-Encoding": "gzip, deflate",
5555
"Host": host,
5656
"User-Agent": request["headers"]["User-Agent"],
57+
"baggage": mock.ANY,
5758
"sentry-trace": mock.ANY,
5859
}
5960

@@ -373,11 +374,13 @@ async def hello(request):
373374

374375
events = capture_events()
375376

376-
trace_id = "582b43a4192642f0b136d5159a501701"
377-
sentry_trace_header = "{}-{}-{}".format(trace_id, "6e8f22c393e68f19", 1)
378-
377+
# The aiohttp_client is instrumented so will generate the sentry-trace header and add request.
378+
# Get the sentry-trace header from the request so we can later compare with transaction events.
379379
client = await aiohttp_client(app)
380-
resp = await client.get("/", headers={"sentry-trace": sentry_trace_header})
380+
resp = await client.get("/")
381+
sentry_trace_header = resp.request_info.headers.get("sentry-trace")
382+
trace_id = sentry_trace_header.split("-")[0]
383+
381384
assert resp.status == 500
382385

383386
msg_event, error_event, transaction_event = events
@@ -411,11 +414,13 @@ async def hello(request):
411414

412415
events = capture_events()
413416

414-
trace_id = "582b43a4192642f0b136d5159a501701"
415-
sentry_trace_header = "{}-{}-{}".format(trace_id, "6e8f22c393e68f19", 1)
416-
417+
# The aiohttp_client is instrumented so will generate the sentry-trace header and add request.
418+
# Get the sentry-trace header from the request so we can later compare with transaction events.
417419
client = await aiohttp_client(app)
418-
resp = await client.get("/", headers={"sentry-trace": sentry_trace_header})
420+
resp = await client.get("/")
421+
sentry_trace_header = resp.request_info.headers.get("sentry-trace")
422+
trace_id = sentry_trace_header.split("-")[0]
423+
419424
assert resp.status == 500
420425

421426
msg_event, error_event = events

0 commit comments

Comments
 (0)