fixup! feat(deno): redis diagnostics channel based integration for deno (#21087)

Author: isaacs

packages/core/src/integrations/redis/redis-dc-subscriber.ts

@@ -27,7 +27,7 @@ const NOOP = (): void => {};
 export interface RedisCommandData {
   command: string;
   /** First arg is the command name itself in node-redis >= 5.12.0; consumers should slice it off. */
-  args: Array<string | Buffer>;
+  args: Array<string | Uint8Array>;
   database?: number;
   serverAddress?: string;
   serverPort?: number;
@@ -65,7 +65,7 @@ export interface RedisConnectData {
 export type RedisDiagnosticChannelResponseHook = (
   span: Span,
   cmdName: string,
-  cmdArgs: Array<string | Buffer>,
+  cmdArgs: Array<string | Uint8Array>,
   result: unknown,
 ) => void;
 
@@ -257,7 +257,7 @@ function setupConnectChannel(tracingChannel: RedisTracingChannelFactory): void {
   });
 }
 
-function runResponseHook(span: Span, command: string, args: Array<string | Buffer>, result: unknown): void {
+function runResponseHook(span: Span, command: string, args: Array<string | Uint8Array>, result: unknown): void {
   const hook = currentResponseHook;
   if (!hook) return;
   try {
@@ -267,7 +267,7 @@ function runResponseHook(span: Span, command: string, args: Array<string | Buffe
   }
 }
 
-function safeSerialize(command: string, args: Array<string | Buffer>): string | undefined {
+function safeSerialize(command: string, args: Array<string | Uint8Array>): string | undefined {
   try {
     return defaultDbStatementSerializer(command, args);
   } catch {

packages/core/src/integrations/redis/redis-statement-serializer.ts

@@ -36,12 +36,12 @@ const SERIALIZATION_SUBSETS: Array<{ regex: RegExp; args: number }> = [
  */
 export function defaultDbStatementSerializer(
   cmdName: string,
-  cmdArgs: Array<string | Buffer | number | unknown[]>,
+  cmdArgs: Array<string | Uint8Array | number | unknown[]>,
 ): string {
   if (!Array.isArray(cmdArgs) || cmdArgs.length === 0) return cmdName;
 
   const budget = SERIALIZATION_SUBSETS.find(({ regex }) => regex.test(cmdName))?.args ?? 0;
-  const argsToSerialize: Array<string | Buffer | number | unknown[]> =
+  const argsToSerialize: Array<string | Uint8Array | number | unknown[]> =
     budget >= 0 ? cmdArgs.slice(0, budget) : cmdArgs.slice();
   if (cmdArgs.length > argsToSerialize.length) {
     argsToSerialize.push(`[${cmdArgs.length - budget} other arguments]`);