ref: Remove splat route handling to simplify matching logic

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: nicohrubec

packages/tanstackstart-react/src/server/routeParametrization.ts

@@ -12,9 +12,6 @@ function patternToRegex(pattern: string): RegExp {
   const segments = pattern
     .split('/')
     .map(segment => {
-      if (segment === '$') {
-        return '.+';
-      }
       if (segment.startsWith('$')) {
         return '[^/]+';
       }
@@ -28,7 +25,7 @@ function patternToRegex(pattern: string): RegExp {
  * Matches a URL pathname against a list of TanStack Start route patterns.
  * Patterns use `$param` syntax for dynamic segments (e.g., `/users/$id`).
  *
- * Patterns are sorted by specificity: more segments first, static before dynamic, splat last.
+ * Patterns are sorted by specificity: more segments first, static before dynamic.
  */
 export function matchUrlToRoutePattern(pathname: string, patterns: string[]): string | undefined {
   const sorted = [...patterns].sort((a, b) => {
@@ -37,11 +34,6 @@ export function matchUrlToRoutePattern(pathname: string, patterns: string[]): st
     if (bSegments.length !== aSegments.length) {
       return bSegments.length - aSegments.length;
     }
-    const aSplat = aSegments.filter(s => s === '$').length;
-    const bSplat = bSegments.filter(s => s === '$').length;
-    if (aSplat !== bSplat) {
-      return aSplat - bSplat;
-    }
     const aDynamic = aSegments.filter(s => s.startsWith('$')).length;
     const bDynamic = bSegments.filter(s => s.startsWith('$')).length;
     return aDynamic - bDynamic;

packages/tanstackstart-react/test/server/routeParametrization.test.ts

@@ -37,21 +37,4 @@ describe('matchUrlToRoutePattern', () => {
     const patternsNested = ['/users/$id', '/users/$id/profile'];
     expect(matchUrlToRoutePattern('/users/123/profile', patternsNested)).toBe('/users/$id/profile');
   });
-
-  it('matches splat/catch-all routes across multiple segments', () => {
-    const patternsWithSplat = ['/', '/files/$'];
-    expect(matchUrlToRoutePattern('/files/a/b/c', patternsWithSplat)).toBe('/files/$');
-    expect(matchUrlToRoutePattern('/files/readme.txt', patternsWithSplat)).toBe('/files/$');
-  });
-
-  it('prefers specific routes over splat routes', () => {
-    const patternsWithSplat = ['/files/$', '/files/upload'];
-    expect(matchUrlToRoutePattern('/files/upload', patternsWithSplat)).toBe('/files/upload');
-    expect(matchUrlToRoutePattern('/files/a/b', patternsWithSplat)).toBe('/files/$');
-  });
-
-  it('prefers named param routes over splat routes with same segment count', () => {
-    const patternsWithBoth = ['/files/$', '/files/$name'];
-    expect(matchUrlToRoutePattern('/files/readme.txt', patternsWithBoth)).toBe('/files/$name');
-  });
 });