Skip to content

Commit d5c230b

Browse files
nicohrubecclaude
andcommitted
fix: Trim server ignoreSpans to only patterns that produce transactions
Only /node_modules/, /@id/, /@react-refresh/, and /@vite/ actually generate server-side http.server transactions in a real browser session. The rest (favicon.ico, /@tanstack-start/, /@fs/) are handled by Vite before reaching Node. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent b806f8e commit d5c230b

2 files changed

Lines changed: 1 addition & 12 deletions

File tree

packages/tanstackstart-react/src/server/sdk.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,8 @@ export function init(options: NodeOptions): NodeClient | undefined {
1616
sentryOptions.ignoreSpans = [
1717
...(sentryOptions.ignoreSpans || []),
1818
/\/node_modules\//,
19-
/\/favicon\.ico/,
2019
/\/@id\//,
2120
/\/@react-refresh/,
22-
/\/@tanstack-start\//,
23-
/\/@fs\//,
2421
/\/@vite\//,
2522
];
2623

packages/tanstackstart-react/test/server/sdk.test.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,7 @@ describe('TanStack Start React Server SDK', () => {
4444

4545
expect(nodeInit).toHaveBeenCalledWith(
4646
expect.objectContaining({
47-
ignoreSpans: expect.arrayContaining([
48-
/\/node_modules\//,
49-
/\/favicon\.ico/,
50-
/\/@id\//,
51-
/\/@react-refresh/,
52-
/\/@tanstack-start\//,
53-
/\/@fs\//,
54-
/\/@vite\//,
55-
]),
47+
ignoreSpans: expect.arrayContaining([/\/node_modules\//, /\/@id\//, /\/@react-refresh/, /\/@vite\//]),
5648
}),
5749
);
5850
});

0 commit comments

Comments
 (0)