Merge branch 'develop' into timfish/feat/V8-v14-support

Author: timfish

.github/workflows/build.yml

@@ -152,9 +152,6 @@ jobs:
       changed_node:
         ${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
         '@sentry/node') }}
-      changed_node_overhead_action:
-        ${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
-        '@sentry-internal/node-overhead-gh-action') }}
       changed_deno:
         ${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
         '@sentry/deno') }}
@@ -208,37 +205,6 @@ jobs:
           # Only run comparison against develop if this is a PR
           comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) ||  ''}}
 
-  job_node_overhead_check:
-    name: Node Overhead Check
-    needs: [job_get_metadata, job_build]
-    timeout-minutes: 15
-    runs-on: ubuntu-24.04
-    if:
-      (needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
-      (needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
-      needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
-    steps:
-      - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
-        uses: actions/checkout@v6
-        with:
-          ref: ${{ env.HEAD_COMMIT }}
-      - name: Set up Node
-        uses: actions/setup-node@v6
-        with:
-          node-version-file: 'package.json'
-      - name: Restore caches
-        uses: ./.github/actions/restore-cache
-        with:
-          dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
-      - name: Check node overhead
-        uses: ./dev-packages/node-overhead-gh-action
-        env:
-          DEBUG: '1'
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          # Only run comparison against develop if this is a PR
-          comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) ||  ''}}
-
   job_lint:
     name: Lint
     # Even though the linter only checks source code, not built code, it needs the built code in order check that all
@@ -605,6 +571,7 @@ jobs:
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           directory: dev-packages/browser-integration-tests
+          enable-coverage: false
           name:
             browser-playwright-${{ matrix.bundle }}-${{ matrix.project }}${{ matrix.shard && format('-{0}',
             matrix.shard) || '' }}
@@ -669,6 +636,7 @@ jobs:
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           directory: dev-packages/browser-integration-tests
+          enable-coverage: false
           name: browser-loader-${{ matrix.bundle }}
 
   job_check_for_faulty_dts:
@@ -737,15 +705,6 @@ jobs:
         working-directory: dev-packages/node-integration-tests
         run: yarn test
 
-      - name: Parse and Upload Coverage
-        if: cancelled() == false
-        continue-on-error: true
-        uses: getsentry/codecov-action@main
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-          directory: dev-packages/node-integration-tests
-          name: node-integration-${{ matrix.node }}${{ matrix.typescript && format('-ts{0}', matrix.typescript) || '' }}
-
   job_node_core_integration_tests:
     name:
       Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Node-Core
@@ -787,16 +746,6 @@ jobs:
         working-directory: dev-packages/node-core-integration-tests
         run: yarn test
 
-      - name: Parse and Upload Coverage
-        if: cancelled() == false
-        continue-on-error: true
-        uses: getsentry/codecov-action@main
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-          directory: dev-packages/node-core-integration-tests
-          name:
-            node-core-integration-${{ matrix.node }}${{ matrix.typescript && format('-ts{0}', matrix.typescript) || ''}}
-
   job_cloudflare_integration_tests:
     name: Cloudflare Integration Tests
     needs: [job_get_metadata, job_build]
@@ -856,15 +805,6 @@ jobs:
           cd packages/remix
           yarn test:integration:ci
 
-      - name: Parse and Upload Coverage
-        if: cancelled() == false
-        continue-on-error: true
-        uses: getsentry/codecov-action@main
-        with:
-          directory: packages/remix
-          token: ${{ secrets.GITHUB_TOKEN }}
-          name: ${{ matrix.node }}
-
   job_e2e_prepare:
     name: Prepare E2E tests
     # We want to run this if:
@@ -1053,15 +993,6 @@ jobs:
           retention-days: 7
           if-no-files-found: ignore
 
-      - name: Parse and Upload Coverage
-        if: cancelled() == false
-        continue-on-error: true
-        uses: getsentry/codecov-action@main
-        with:
-          directory: dev-packages/e2e-tests
-          token: ${{ secrets.GITHUB_TOKEN }}
-          name: e2e-${{ matrix.test-application }}
-
   # - We skip optional tests on release branches
   job_optional_e2e_tests:
     name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)

.github/workflows/ci-metadata.yml

@@ -61,7 +61,7 @@ jobs:
 
       # Most changed packages are determined in job_build via Nx
       - name: Determine changed packages
-        uses: dorny/paths-filter@v3.0.1
+        uses: dorny/paths-filter@v4.0.1
         id: changed
         with:
           filters: |

.github/workflows/flaky-test-detector.yml

@@ -55,7 +55,7 @@ jobs:
           browsers: 'chromium'
 
       - name: Determine changed tests
-        uses: dorny/paths-filter@v3.0.1
+        uses: dorny/paths-filter@v4.0.1
         id: changed
         with:
           list-files: json

dev-packages/cloudflare-integration-tests/suites/tracing/propagation/worker-do/index.ts

@@ -8,7 +8,7 @@ interface Env {
 }
 
 class MyDurableObjectBase extends DurableObject<Env> {
-  async fetch(request: Request) {
+  async fetch(_request: Request) {
     return new Response('DO is fine');
   }
 }

dev-packages/cloudflare-integration-tests/suites/tracing/propagation/worker-service-binding/index-sub-worker.ts

@@ -5,7 +5,7 @@ interface Env {
 }
 
 const myWorker = {
-  async fetch(request: Request) {
+  async fetch(_request: Request) {
     return new Response('Hello from another worker!');
   },
 };

dev-packages/cloudflare-integration-tests/suites/tracing/propagation/workflow-do/index.ts

@@ -9,7 +9,7 @@ interface Env {
 }
 
 class MyDurableObjectBase extends DurableObject<Env> {
-  async fetch(request: Request) {
+  async fetch(_request: Request) {
     return new Response('DO is fine');
   }
 }

dev-packages/node-core-integration-tests/suites/anr/app-path.mjs

@@ -25,7 +25,7 @@ Sentry.setUser({ email: 'person@home.com' });
 Sentry.addBreadcrumb({ message: 'important message!' });
 
 function longWork() {
-  for (let i = 0; i < 20; i++) {
+  for (let i = 0; i < 50; i++) {
     const salt = crypto.randomBytes(128).toString('base64');
     const hash = crypto.pbkdf2Sync('myPassword', salt, 10000, 512, 'sha512');
     assert.ok(hash);

dev-packages/node-core-integration-tests/suites/anr/basic-multiple.mjs

@@ -21,7 +21,7 @@ Sentry.setUser({ email: 'person@home.com' });
 Sentry.addBreadcrumb({ message: 'important message!' });
 
 function longWork() {
-  for (let i = 0; i < 20; i++) {
+  for (let i = 0; i < 50; i++) {
     const salt = crypto.randomBytes(128).toString('base64');
     const hash = crypto.pbkdf2Sync('myPassword', salt, 10000, 512, 'sha512');
     assert.ok(hash);

dev-packages/node-core-integration-tests/suites/anr/basic-session.js

@@ -20,7 +20,7 @@ Sentry.setUser({ email: 'person@home.com' });
 Sentry.addBreadcrumb({ message: 'important message!' });
 
 function longWork() {
-  for (let i = 0; i < 20; i++) {
+  for (let i = 0; i < 50; i++) {
     const salt = crypto.randomBytes(128).toString('base64');
     const hash = crypto.pbkdf2Sync('myPassword', salt, 10000, 512, 'sha512');
     assert.ok(hash);

dev-packages/node-core-integration-tests/suites/anr/basic.js

@@ -22,7 +22,7 @@ Sentry.setUser({ email: 'person@home.com' });
 Sentry.addBreadcrumb({ message: 'important message!' });
 
 function longWork() {
-  for (let i = 0; i < 20; i++) {
+  for (let i = 0; i < 50; i++) {
     const salt = crypto.randomBytes(128).toString('base64');
     const hash = crypto.pbkdf2Sync('myPassword', salt, 10000, 512, 'sha512');
     assert.ok(hash);