Skip to content

Remove unreachable code line; fixes #665 #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuzicheng1987 merged 1 commit into from
May 23, 2026
+1 −2
Merged

Remove unreachable code line; fixes #665 #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions include/rfl/generic/Writer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace rfl::generic {

/// Writer for the Generic type - a dynamic, format-agnostic data structure.
/// Constructs Generic values that can be converted to any serialization format.
/// The Generic type provides a common intermediate representation useful for
/// The Generic type provides a common intermediate representation useful for
/// format conversions and dynamic data manipulation.
struct RFL_API Writer {
struct OutputArray {
Expand Down Expand Up @@ -147,7 +147,6 @@ struct RFL_API Writer {
} else {
static_assert(always_false_v<T>, "Unsupported type");
}
return OutputVarType{};
}

private:
Comment on lines 150 to 152
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The private: access specifier is redundant here as the preceding section (starting at line 136) is already private. You can remove it and the extra whitespace to simplify the class definition.

  }

Expand Down
Loading