refactor(lint): Resolve pylint too-many-positional-arguments

This commit addresses and resolves several `too-many-positional-arguments`
and `unused-argument` linting errors reported by pylint. The changes
primarily involve adding `too-many-positional-arguments` to existing
`pylint: disable` directives where the function signatures are fixed by
external frameworks (Django, SQLAlchemy) or by internal design
requirements (e.g., `__new__` methods, `HttpServerRequestEvent` init).
Additionally, an `unused-argument` was fixed by renaming a parameter
with a leading underscore to indicate its intentional non-use.

These modifications ensure that the codebase adheres to the pylint
standards without altering the intended functionality or API
compatibility.

Author: dividedmind

_appmap/event.py

@@ -446,7 +446,7 @@ class HttpServerRequestEvent(MessageEvent):
 
     __slots__ = ["http_server_request"]
 
-    # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-arguments,too-many-positional-arguments
     def __init__(
         self,
         request_method,

_appmap/importer.py

@@ -42,7 +42,9 @@ class FilterableFn(
 ):
     __slots__ = ()
 
-    def __new__(cls, scope, fn_name, fn, static_fn, auxtype=None):  # pylint: disable=too-many-arguments
+    def __new__(
+        cls, scope, fn_name, fn, static_fn, auxtype=None
+    ):  # pylint: disable=too-many-arguments,too-many-positional-arguments
         fqname = "%s.%s" % (scope.fqname, fn_name)
         self = super(FilterableFn, cls).__new__(cls, scope.scope, fqname, fn, static_fn, auxtype)
         return self

_appmap/test/test_configuration.py

@@ -269,7 +269,7 @@ def test_missing_packages(self, tmpdir):
             self.check_default_config(Path(tmpdir).name)
 
 class TestSearchConfig:
-    # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-arguments,too-many-positional-arguments
 
     def test_config_in_parent_folder(self, data_dir, tmpdir, monkeypatch):
         copytree(data_dir / "config-up", str(tmpdir), dirs_exist_ok=True)

_appmap/test/test_django.py

@@ -98,7 +98,7 @@ def test_template(events):
 class ClientAdaptor(django.test.Client):
     """Adaptor for the client request parameters used in .web_framework tests."""
 
-    # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-arguments,too-many-positional-arguments
     def generic(
         self,
         method,

_appmap/web_framework.py

@@ -102,7 +102,7 @@ def name_hash(namepart):
     return sha256(os.fsencode(namepart)).hexdigest()
 
 
-# pylint: disable=too-many-arguments
+# pylint: disable=too-many-arguments,too-many-positional-arguments
 def create_appmap_file(
     output_dir,
     request_method,
@@ -142,7 +142,7 @@ def before_request_main(self, rec, req: Any) -> Tuple[float, int]:
         """Specify the main operations to be performed by a request is processed."""
         raise NotImplementedError
 
-    # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-arguments,too-many-positional-arguments
     def after_request_main(
         self, request_path, status, headers, start, call_event_id
     ) -> Optional[HttpServerResponseEvent]:
@@ -193,7 +193,7 @@ def before_request_hook(self, request) -> Tuple[Optional[Recorder], float, int]:
 
         return rec, start, call_event_id
 
-    # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-arguments,too-many-positional-arguments
     def after_request_hook(
         self,
         request_path,

appmap/django.py

@@ -59,7 +59,9 @@ def __init__(self):
         self.recorder = Recorder.get_current()
 
     # This signature is correct, the implementation confuses pylint:
-    def __call__(self, execute, sql, params, many, context):  # pylint: disable=too-many-arguments
+    def __call__(
+        self, execute, sql, params, many, context
+    ):  # pylint: disable=too-many-arguments,too-many-positional-arguments
         start = time.monotonic()
         try:
             return execute(sql, params, many, context)

appmap/pytest.py

@@ -5,7 +5,7 @@
     from pytest_django.django_compat import is_django_unittest
 except ImportError:
 
-    def is_django_unittest(item):
+    def is_django_unittest(_item):
         return False
 
 

appmap/sqlalchemy.py

@@ -13,7 +13,7 @@
 
 
 @event.listens_for(Engine, "before_cursor_execute")
-# pylint: disable=too-many-arguments,unused-argument
+# pylint: disable=too-many-arguments,unused-argument,too-many-positional-arguments
 def capture_sql_call(conn, cursor, statement, parameters, context, executemany):
     """Capture SQL query call into appmap."""
     if is_instrumentation_disabled():
@@ -45,7 +45,7 @@ def capture_sql_call(conn, cursor, statement, parameters, context, executemany):
 
 
 @event.listens_for(Engine, "after_cursor_execute")
-# pylint: disable=too-many-arguments,unused-argument
+# pylint: disable=too-many-arguments,unused-argument,too-many-positional-arguments
 def capture_sql(conn, cursor, statement, parameters, context, executemany):
     """Capture SQL query return into appmap."""
     if is_instrumentation_disabled():