[FeatureEditor] - Allow editing by fields

[Gaetanbrl]

ref PR #10524

Description

According to the new Fields UI, it could be usefull to manage edition by fields.

This could be an answer to this use case :

As data manager (e.g natural area)
I need to use a configuration from fields UI
to allow some reporters to complete the land use value but prevent them to change assigned operator

Many way exists to do that.

I propose first to manage this by customEditorOptions in order to use regeEx control on field name. Then, editors can catch the props and affect editable value (true/false).

Next, I imagine in a second time to manage this type of configuration by the new fields UI. This requires to create a new columns in Fields table but it could be less good than expected. So, another way to do that in fields is to create a "settings" button by fields to open a modal and display many options as allowEdit and future improvements (i will create new ones).

I know that geoserver will always allow edition if someone use Qgis with the correct credentials, but we have many cases where basic user profile just use mapstore and needs to be regulated.

What kind of improvement you want to add? (check one with "x", remove the others)

• Minor changes to existing features
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

Other useful information

Please, share your point of view and technical advices according to mapstore2 good practices and possibility.

[Gaetanbrl]

Currently, if we add editable prop by field for FeatureEditor plugin, this not works fine because editor mode can be activate from each other editable column.

By default, react-data-grid seems correctly check that field is editable or not and need a dble click to open cell editor view.
Here a native example where only 2/3 cols are editable :

https://codepen.io/gaetanbrl/pen/OJqyZzQ

Here mapstore example where NOM column have editable: false prop but user can always edit if editor is activated from other column :

Maybe MapStore2 gridEvents (or other code) is not compliant with this dev and needs to be change (i will analyse that now).

[Gaetanbrl]

@offtherailz do you know why cell editor still open when we click on other cell ? is this what you want ?

[Gaetanbrl]

I found 2 others alternatives.

Solution - Use disabled props on each Editor

tested and works fine

This solution needs to change Editor code to insert disabled property if the column is not editable.

MapStore2/web/client/components/data/featuregrid/editors/FormatEditor.jsx

Lines 61 to 65 in b91cd22

	render() {
	return (<input
	{...this.props.inputProps}
	style={!this.state.validated || this.state.isValid ? {} : {
	borderColor: 'red'

Here, the nom field is disabled and cursor show red circle on hover (ease to understand by all users) :

Solution - Return null Editor

tested and works fine

The solution needs to change Editor code to render null if the column is not editable.

Here, the nom field is not editable :

Here an Editor (<input>) code example for this solution :

[Gaetanbrl]

According to https://groups.google.com/g/mapstore-developers/c/D717X0rzQHQ

This issue will include possibility to edit geometry or not.

The pull request will contains more details.