Can't select item of combobox in modal dialog

[AndyGeng123]

test.zip

[AndyGeng123]

Describe the bug

Give a detailed description of what the bug is.
I create a Main Window class "MainWindow", and create a modal dialog "TestDialog",
void TestMainWindow::showTestDialog()
{
TestDialog form{ this };
form.setModal(true);
form.show();
}

TestDialog is shown in modal dialog, but when I click combobox items, it does't work.

How to reproduce the bug?

1. Open the MainWindow, click File-> "Test Dialog" menu item,
2. Click the combobox, items popup, but can't be choosed.

What behavior did you expect?

combobox should work in modal dialog.

In which environment did the bug occur?

• Which operating system do you use?
  
  Linux

• Which distribution do you use?
  Redhat 6.

• On which CPU architecture did you test?
  x64.

• Which compiler in which version did you use?
  gcc 6.5 c++14, and changed some constexpr functions to const for compling error.

• Which terminal do you use?
  SecureCRT, xshell.

• What does the environment variable $TERM contain?
  xterm

[gansm]

Hi Andy,

Thank you for reporting this issue. Events sent to widgets that are not client widgets of the modal window are ignored. The drop-down list box of the combo box widget is a non-modal window, so user events are not processed there. I will look for a solution and update you on my progress soon.

Cheers,
Markus

[gansm]

Hi Andy,

I've now found a solution (dc5b3b9) and hope it's general enough to cover all possible scenarios.

Cheers,
Markus

[gansm]

Useful tip: If you want to maximize the height of a window, and you're using a menu bar and/or a status bar, use parent->getClientHeight() instead of getDesktopHeight().

TestMainWindow::TestMainWindow (finalcut::FWidget* parent)
  : finalcut::FDialog{parent}
{
  auto width = getDesktopWidth();
  //auto height = getDesktopHeight();
  auto height = parent->getClientHeight();
  ...
}

void TestMainWindow::adjustSize()
{
  finalcut::FDialog::adjustSize();
  const std::size_t w = getDesktopWidth();
  //const std::size_t h = getDesktopHeight();
  auto parent = getParentWidget();
  const std::size_t h = parent->getClientHeight();
  setSize({w, h});
}

[AndyGeng123]

Hi Gansm,
Thanks for your rapid response.
I test again for combobox, it works.
When I take a further test on combobox, how can I get the current index of combobox?

//set signal
TestDialog::TestDialog(finalcut::FWidget* parent) : finalcut::FDialog{ parent }
{
FDialog::setText("Test Dialog");

testCombo.setLabelText(L"List Value:");
testCombo.unsetEditable();
int i = 0;
for (auto c : test_combo_vals)
{
    finalcut::FListBoxItem item(c, i++);
    testCombo.insert(item);
}

for (const auto& signal : { "row-changed", "clicked" })
{
    testCombo.addCallback
    (
        signal,
        this, &TestDialog::cb_choice
    );
}

...
}

//nIndex is NOT currect.
void TestDialog::cb_choice()
{
int nIndex = testCombo.getItemData();
char s_val[64];
sprintf(s_val, "%d", nIndex);
this->edtComboValue.setText(s_val);
}

[AndyGeng123]

test.zip

[gansm]

Hi Andy,
I assume you want to read the value of the data field for the currently selected item and display it directly in the list box. The only thing missing from your code is the redraw after the value changes.

void TestDialog::cb_choice()
{
  // Get the item data as string value
  using output_type = int;
  auto value = testCombo.getItemData<output_type>();
  auto string_value = std::to_string(value);

  // Get the item text as string value
  //auto string_value = testCombo.getText();

  // Replace the list box text with the string value
  edtComboValue.setText(string_value);

  // Redraw the list box with the new value
  edtComboValue.redraw();
}

[AndyGeng123]

Hi Gansm,
In fact, I want to get the current selected index.
Some GUI library have such a method, for example, In QT, there is a method "currentIndex()" to get current index.

I added a method in FComboBox class:
<
finalcut-main\final\widget\fcombobox.h
void setCurrentItem (std::size_t);
int getCurrentItem() const
{
const std::size_t index = list_window.list.currentItem();
return index;
}

Thanks again.

[gansm]

Hi Andy,
That sounds useful!
Could you please send me a pull request with your changes?

[AndyGeng123]

Sorry Gansm,
I am not familar with "pull request" function, could you help to do this?

Here is contents:
<
Many GUI libraries have a method to get current index of ComboBox,
For example, QT has a method "currentIndex()" to get current index.

There should be a method in FComboBox class:
<
$ vi finalcut-main\final\widget\fcombobox.h
int getCurrentItem() const
{
const std::size_t index = list_window.list.currentItem();
return index;
}
Many Thanks.

[gansm]

Sorry Gansm,
I am not familar with "pull request" function, could you help to do this?

Sure, I can help you with that.

1. Create your own fork of FINAL CUT (https://github.com/gansm/finalcut/fork)

2. Create a new branch and name it, e.g. “patch1” (https://github.com/AndyGeng123/finalcut/branches)

3. Make your code changes ...

4. Create a pull request as described here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

5. Become part of the great open-source community ;)