Skip to content

Commit 7acb21d

Browse files
committed
Fixed orderBy keys on iOS
1 parent 502cf35 commit 7acb21d

File tree

2 files changed

+31
-22
lines changed

2 files changed

+31
-22
lines changed

ios/Firestack/FirestackDatabase.m

Lines changed: 29 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -67,36 +67,44 @@ - (FIRDatabaseQuery *) getQueryWithModifiers:(NSArray *) modifiers
6767
query = [query queryLimitedToFirst:limit];
6868
} else if ([str containsString:@"equalTo"]) {
6969
NSArray *args = [str componentsSeparatedByString:@":"];
70-
NSString *value = args[1];
71-
NSString *key = args[2];
72-
73-
if (key == nil) {
74-
query = [query queryEqualToValue:value];
75-
} else {
76-
query = [query queryEqualToValue:value
70+
int size = (int)[args count];;
71+
72+
if (size > 2) {
73+
NSString *value = args[1];
74+
NSString *key = args[2];
75+
76+
query = [query queryEqualToValue:value
7777
childKey:key];
78+
} else {
79+
NSString *value = args[1];
80+
query = [query queryEqualToValue:value];
7881
}
7982
} else if ([str containsString:@"endAt"]) {
8083
NSArray *args = [str componentsSeparatedByString:@":"];
81-
NSString *value = args[1];
82-
NSString *key = args[2];
83-
84-
if (key == nil) {
85-
query = [query queryEndingAtValue:value];
86-
} else {
87-
query = [query queryEndingAtValue:value
84+
int size = (int)[args count];;
85+
86+
if (size > 2) {
87+
NSString *value = args[1];
88+
NSString *key = args[2];
89+
90+
query = [query queryEndingAtValue:value
8891
childKey:key];
92+
} else {
93+
NSString *value = args[1];
94+
query = [query queryEndingAtValue:value];
8995
}
9096
} else if ([str containsString:@"startAt"]) {
9197
NSArray *args = [str componentsSeparatedByString:@":"];
92-
NSString *value = args[1];
93-
NSString *key = args[2];
94-
95-
if (key == nil) {
96-
query = [query queryStartingAtValue:value];
97-
} else {
98-
query = [query queryStartingAtValue:value
98+
int size = (int)[args count];;
99+
if (size > 2) {
100+
NSString *value = args[1];
101+
NSString *key = args[2];
102+
103+
query = [query queryStartingAtValue:value
99104
childKey:key];
105+
} else {
106+
NSString *value = args[1];
107+
query = [query queryStartingAtValue:value];
100108
}
101109
}
102110
}

lib/modules/database.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ class DatabaseQuery {
9696
.forEach(key => {
9797
const filter = this.filters[key];
9898
if (filter) {
99-
modifiers.push(filter.join(argsSeparator));
99+
const filterArgs = [key, filter].join(argsSeparator)
100+
modifiers.push(filterArgs);
100101
}
101102
})
102103
return modifiers;

0 commit comments

Comments
 (0)