Skip to content

Commit 70f68f2

Browse files
authored
Merge pull request #23 from saleeh93/master
Facebook login fix android
2 parents 05ede56 + 25f74e7 commit 70f68f2

File tree

3 files changed

+17
-8
lines changed

3 files changed

+17
-8
lines changed

android/src/main/java/io/fullstack/firestack/FirestackAuth.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ public void onComplete(@NonNull Task<AuthResult> task) {
136136

137137
@ReactMethod
138138
public void signInWithProvider(final String provider, final String authToken, final String authSecret, final Callback callback) {
139+
if (provider.equals("facebook")) {
140+
this.facebookLogin(authToken,callback);
141+
} else
139142
// TODO
140143
FirestackUtils.todoNote(TAG, "signInWithProvider", callback);
141144
}
@@ -403,17 +406,23 @@ public void userCallback(FirebaseUser passedUser, final Callback onComplete) {
403406
@Override
404407
public void onComplete(@NonNull Task<GetTokenResult> task) {
405408
WritableMap userMap = Arguments.createMap();
406-
409+
final String name = user.getDisplayName();
407410
final String token = task.getResult().getToken();
408411
final String email = user.getEmail();
409412
final String uid = user.getUid();
410413
final String provider = user.getProviderId();
414+
final Uri photoUrl = user.getPhotoUrl();
411415

416+
userMap.putString("name", name);
412417
userMap.putString("token", token);
413418
userMap.putString("email", email);
414419
userMap.putString("uid", uid);
415420
userMap.putString("provider", provider);
416421

422+
if (photoUrl!=null) {
423+
userMap.putString("photoUrl",photoUrl.toString());
424+
}
425+
417426
onComplete.invoke(null, userMap);
418427
}
419428
});
@@ -451,4 +460,4 @@ private WritableMap getUserMap() {
451460
}
452461

453462

454-
}
463+
}

android/src/main/java/io/fullstack/firestack/FirestackDatabase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ public void on(final String path,
391391
@ReactMethod
392392
public void onOnce(final String path,
393393
final ReadableArray modifiers,
394-
final String name,
394+
final String name,
395395
final Callback callback) {
396396
Log.d(TAG, "Setting one-time listener on event: " + name + " for path " + path);
397397
FirestackDBReference ref = this.getDBHandle(path);
@@ -518,7 +518,7 @@ private FirestackDBReference getDBHandle(final String path) {
518518
return mDBListeners.get(path);
519519
}
520520

521-
private void saveDBHandle(final String path,
521+
private void saveDBHandle(final String path,
522522
final FirestackDBReference dbRef) {
523523
this.removeDBHandle(path);
524524
mDBListeners.put(path, dbRef);

android/src/main/java/io/fullstack/firestack/FirestackStorage.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public void onSuccess(Uri uri) {
7979
}
8080
}).addOnFailureListener(new OnFailureListener() {
8181
@Override
82-
public void onFailure(@NonNull Exception ex) {
82+
public void onFailure(@NonNull Exception exception) {
8383
Log.e(TAG, "Failed to download file " + exception.getMessage());
8484

8585
WritableMap err = Arguments.createMap();
@@ -88,7 +88,7 @@ public void onFailure(@NonNull Exception ex) {
8888

8989
callback.invoke(err);
9090
}
91-
})
91+
});
9292
}
9393

9494
// STORAGE
@@ -157,7 +157,7 @@ public void onSuccess(UploadTask.TaskSnapshot taskSnapshot) {
157157
public void onProgress(UploadTask.TaskSnapshot taskSnapshot) {
158158
double progress = (100.0 * taskSnapshot.getBytesTransferred()) / taskSnapshot.getTotalByteCount();
159159
System.out.println("Upload is " + progress + "% done");
160-
160+
161161
WritableMap data = Arguments.createMap();
162162
data.putString("eventName", "upload_progress");
163163
data.putDouble("progress", progress);
@@ -184,4 +184,4 @@ public void onPaused(UploadTask.TaskSnapshot taskSnapshot) {
184184
callback.invoke(err);
185185
}
186186
}
187-
}
187+
}

0 commit comments

Comments
 (0)