@@ -277,7 +277,7 @@ public void googleLogin(String IdToken, final Callback callback) {
277277 public void onComplete (@ NonNull Task <AuthResult > task ) {
278278 if (task .isSuccessful ()) {
279279 user = task .getResult ().getUser ();
280- userCallback (onSuccess );
280+ userCallback (user , callback );
281281 }else {
282282 userErrorCallback (task , onFail );
283283 }
@@ -286,7 +286,7 @@ public void onComplete(@NonNull Task<AuthResult> task) {
286286 }
287287
288288 @ ReactMethod
289- public void facebookLogin (String Token , final Callback onSuccess , final Callback onFail ) {
289+ public void facebookLogin (String Token , final Callback callback ) {
290290 mAuth = FirebaseAuth .getInstance ();
291291
292292 AuthCredential credential = FacebookAuthProvider .getCredential (Token );
@@ -296,7 +296,7 @@ public void facebookLogin(String Token, final Callback onSuccess, final Callback
296296 public void onComplete (@ NonNull Task <AuthResult > task ) {
297297 if (task .isSuccessful ()) {
298298 user = task .getResult ().getUser ();
299- userCallback (onSuccess );
299+ userCallback (user , callback );
300300 }else {
301301 userErrorCallback (task , onFail );
302302 }
@@ -311,11 +311,13 @@ public void uploadFile(final String name, final String filepath, final ReadableM
311311 todoNote ("uploadFile" , callback );
312312 }
313313
314+ // Internal helpers
315+
314316 // TODO NOTE
315317 public void todoNote (final String name , final Callback callback ) {
316318 Log .e (TAG , "The method " + name + " has not yet been implemented." )
317319 Log .e (TAG , "Feel free to contribute to finish the method in the source." )
318-
320+
319321 WritableMap errorMap = Arguments .createMap ();
320322 errorMap .putString ("error" , "unimplemented" );
321323 callback .invoke (errorMap );
0 commit comments