fsdocs build does not discover projects from `.slnx` solution files

[sangkilc]

fsdocs build currently auto-discovers projects from a solution only when the working directory contains exactly one .sln file.

With the newer .slnx solution format, project cracking falls back to the shallow *.fsproj directory scan instead of loading projects from the solution. This can miss projects that are included in the solution but live outside the fallback scan depth.

Relevant line:

FSharp.Formatting/src/fsdocs-tool/ProjectCracker.fs

Line 510 in 4ed3a99

match Directory.GetFiles(slnDir, "*.sln") with

Possible single-line patch

--- a/src/fsdocs-tool/ProjectCracker.fs
+++ b/src/fsdocs-tool/ProjectCracker.fs
@@ -507,7 +507,7 @@ module Crack =
         let collectionName, projectFiles =
             match projects, ignoreProjects with
             | [], false ->
-                match Directory.GetFiles(slnDir, "*.sln") with
+                match Array.append (Directory.GetFiles(slnDir, "*.sln")) (Directory.GetFiles(slnDir, "*.slnx")) with
                 | [| sln |] ->
                     printfn "getting projects from solution file %s" sln

[nojaf]

Hey, thanks for bringing this up.

Would "*.sln*" also work here?
slnf also appears to be a thing: https://github.com/ionide/proj-info/blob/35d34d3e2181e476d3c008c291670253eee35afc/src/Ionide.ProjInfo/InspectSln.fs#L59

Would you like to send a PR for this?

[sangkilc]

Would *.sln* also work here?

The only downside here is that this will match other files like .sln.bak, etc.

Would you like to send a PR for this?

Sure happy to help. Just let me know which direction works better.

[nojaf]

Maybe

Directory.GetFiles(slnDir, "*.sln*") 
|> Seq.tryFind(fun path -> 
    path.EndsWith(".sln",  StringComparison.Ordinal) 
    || path.EndsWith(".slnx",  StringComparison.Ordinal)
)

Array.append (Directory.GetFiles(slnDir, "*.sln")) (Directory.GetFiles(slnDir, "*.slnx")) would process the directory twice, append all results and then check if there is only one.

tryFind seems slightly better to me, but it is a nitpick for sure.