Skip to content

[Table] td cells in header are unstyled #3250

@AllanJard

Description

@AllanJard

Bug Report

It is valid to have td as well as th cells in a table header, and this is reasonably common in cases where there are multiple rows. The Fomantic code will style th cells in the header with padding, color, etc, but td cells are not.

This is due to the selector .ui.table > thead > tr > th in table.less.

It is worth noting that cells in the footer do not have this issue due to the following selector already being used:

.ui.table > tfoot > tr > th,
.ui.table > tfoot > tr > td {

I would actually propose for both that .ui.table > thead > tr > * be used (and similar for tfoot) since only th and td are valid.

Steps to reproduce

  1. https://jsfiddle.net/87jtmac0/
  2. Note that the cells in the second row of the header do not have any padding.

Expected result

The td and th cells in the header should have similar styling. Possibly you might want the font-weight to be reduced for td?

Actual result

There is no padding or other relevant styles applied to the td cells in the header.

Testcase

https://jsfiddle.net/87jtmac0/

Screenshot (if possible)

Image

Version

2.9.4. Current release at time of writing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    state/awaiting-investigationAnything which needs more investigationtype/bugAny issue which is a bug or PR which fixes a bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions