Description
UninstallRemediation.Reconcile is the only action reconciler that does not call defer summarize(req). All other reconcilers include this deferred call:
Install (install.go:79)
Upgrade (upgrade.go:75)
Test (test.go:78)
Uninstall (uninstall.go:88)
Unlock (unlock.go:64)
RollbackRemediation (rollback_remediation.go:82)
The summarize function propagates sub-conditions (Released, Remediated, TestSuccess) into the top-level Ready condition and refreshes ObservedPostRenderersDigest / ObservedCommonMetadataDigest.
UninstallRemediation is a ReconcilerTypeRemediate, so after it runs, AtomicRelease.strategy.MustStop() returns true and the outer loop exits without its own summarize call. This means the Ready condition is never updated after an uninstall remediation, leaving stale status until the next reconciliation pass.
Steps to Reproduce
- Configure a HelmRelease with uninstall remediation strategy
- Trigger a failed upgrade that activates uninstall remediation
- Observe that the
Ready condition is not updated after remediation completes
Expected Behavior
The Ready condition should be updated after uninstall remediation, consistent with all other reconcilers.
Description
UninstallRemediation.Reconcileis the only action reconciler that does not calldefer summarize(req). All other reconcilers include this deferred call:Install(install.go:79)Upgrade(upgrade.go:75)Test(test.go:78)Uninstall(uninstall.go:88)Unlock(unlock.go:64)RollbackRemediation(rollback_remediation.go:82)The
summarizefunction propagates sub-conditions (Released,Remediated,TestSuccess) into the top-levelReadycondition and refreshesObservedPostRenderersDigest/ObservedCommonMetadataDigest.UninstallRemediationis aReconcilerTypeRemediate, so after it runs,AtomicRelease.strategy.MustStop()returnstrueand the outer loop exits without its own summarize call. This means theReadycondition is never updated after an uninstall remediation, leaving stale status until the next reconciliation pass.Steps to Reproduce
Readycondition is not updated after remediation completesExpected Behavior
The
Readycondition should be updated after uninstall remediation, consistent with all other reconcilers.