Skip to content

profiler-cli function annotate command doesn't look at the symbol server in the redux state #6050

@canova

Description

@canova

I was trying out samply with the profiler-cli. I captured a profile with samply, and kept its symbol server alive, then I loaded it using the cli and tried looking at its assembly. Currently this works:

pq load "https://profiler.firefox.com/from-url/http%3A%2F%2F127.0.0.1%3A3000%2F265hxd3f7qgbga3l5i2qm10dp4hycqy6qxrlq1l%2Fprofile.json/flame-graph/?assemblyView=3~be78~2c~__select&globalTrackOrder=0&symbolServer=http%3A%2F%2F127.0.0.1%3A3000%2F265hxd3f7qgbga3l5i2qm10dp4hycqy6qxrlq1l&thread=0&v=16"
pq function annotate  f-58 --mode asm --symbol-server http://127.0.0.1:3000/265hxd3f7qgbga3l5i2qm10dp4hycqy6qxrlq1l

But ideally we don't have to specify a --symbol-server because we already pass this inside the profile link. I thought I already implemented this in the cli, because we are properly initializing the url state now while loading the profiles, and it works for the symbolication. But apparently I missed it for the pq function annotate command. Currently, it only looks at its --symbol-server argument. We should change this to:

  1. Look at the --symbol-server and use it if it's there.
  2. Use the symbol server from the redux state.

Currently 2nd option is not implemented.

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

Labels

cliIssues related to the profiler CLI

Type

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions