Issue Description
The SCORE2-Diabetes implementation (PR #16) includes test structure with placeholder values that need to be calculated and validated using MDCalc before the tests can be properly executed.
Problem
- All test expected values in
tests/test_score2_diabetes.py are placeholders (0.00, "PLACEHOLDER")
- Test assertions are commented out, preventing actual validation
- 6 test cases covering diverse scenarios need proper expected values calculated
Test Cases Requiring Validation
Test Files in tests/inputs/score2_diabetes/:
- Patient 01: Male, 45 years, non-smoker, good diabetes control (HbA1c: 48)
- Patient 02: Female, 55 years, smoker, poor control (HbA1c: 58)
- Patient 03: Male, 65 years, non-smoker, very poor control (HbA1c: 68, low eGFR: 60)
- Patient 04: Female, 48 years, non-smoker, excellent control (HbA1c: 42)
- Patient 05: Male, 60 years, smoker, poor control (HbA1c: 75, very low eGFR: 50)
- Patient 06: Female, 42 years, smoker, moderate control (HbA1c: 53)
Required Actions
Phase 1: Calculate Expected Values
Phase 2: Update Test File
Phase 3: Comprehensive Edge Case Testing
Example Expected Format
@pytest.mark.parametrize(
"filename,expected",
[
("test__input__patient_01.json", (45.00, 8.52, "High")), # Example values
("test__input__patient_02.json", (55.00, 12.34, "Very high")),
# ... etc
],
)
Success Criteria
Priority
High - This blocks proper validation of the SCORE2-Diabetes implementation
Related
Notes
- Use Belgium (Low Risk) region calibration as implemented
- Ensure calculated values match the implementation's Belgium calibration
- Consider adding comments explaining specific risk scenarios for each test case
Issue Description
The SCORE2-Diabetes implementation (PR #16) includes test structure with placeholder values that need to be calculated and validated using MDCalc before the tests can be properly executed.
Problem
tests/test_score2_diabetes.pyare placeholders (0.00,"PLACEHOLDER")Test Cases Requiring Validation
Test Files in
tests/inputs/score2_diabetes/:Required Actions
Phase 1: Calculate Expected Values
Phase 2: Update Test File
Phase 3: Comprehensive Edge Case Testing
Example Expected Format
Success Criteria
make testPriority
High - This blocks proper validation of the SCORE2-Diabetes implementation
Related
specs/score2_diabetes.mdtests/test_score2.pyNotes