Issue with xrft for next release

[mdtanker]

Description of the problem:

I'm trying to publish a new package on conda-forge which relies on harmonica and am having issues creating a working recipl.yml due to an issues with the latest release of xrft, v1.0.2. I think this is linked to this issue: xgcm/xrft#221. When this version is installed, the system seems to think the installed version is actually 0.0.0 instead of 1.0.2 which then causes compatibility errors since harmonica requires >1.0. Before we make our less release, hopefully the above linked issues is fixed, or if not we may need to pin our dependecy to >1.0,<1.0.2.

Not sure if this is an actually issue that requires a fix now, or just before the next release. I can try and create an new environment and see if I get an issue.

[mdtanker]

Nevermind I think this was just a local issue, closing while I confirm.

Ok can confirm now this is not a local issue. I have asked for help on the conda-forge feedstock here and will see what they suggest as a solution.

[santisoler]

Thanks for reporting this, @mdtanker! This might be a problem on our end since we depend on xrft. Our latest tests are still installing xrft 1.0.1, so apparently we are not testing Harmonica against it yet. Not sure why it's not installing 1.0.2 though.

It might be a good idea to exclude 1.0.2. I wouldn't constrain on xrft>=1.0,<1.0.2 because we might want to allow future users to install 1.0.3. Maybe we can do exclusion instead: xrft >=1.0, !=1.0.2

[santisoler]

I suspect that since the issue is with the released wheel, they'll have to patch it, release 1.0.3, and yank 1.0.2 so it never gets installed.

[mdtanker]

After a bit of testing, I was getting the same issue of having a pip version 0.0.0 when I installed xrft with conda for versions 1.0.0, 1.0.1 and 1.0.2, so im not sure its just an issue with 1.0.2.