Skip to content

Commit f982ef3

Browse files
ahornbymeta-codesync[bot]
authored andcommitted
fix folly tests in getdeps --shared-lib build
Summary: X-link: facebook/folly#2539 Fix folly tests when run with --shared-libs and add CI for it so that the tests register with testx. Motivation: the folly python/cython extensions require that folly is built in shared library mode, and thrift-python requites folly python/cython Reviewed By: bigfootjon Differential Revision: D88502996 fbshipit-source-id: 2846bb9ed60fb59722d1aac99ab0661edc13fd87
1 parent a9e9d01 commit f982ef3

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

build/fbcode_builder/getdeps.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1180,6 +1180,9 @@ def write_job_for_platform(self, platform, args): # noqa: C901
11801180
if override_build_type:
11811181
build_type_arg = f"--build-type {override_build_type} "
11821182

1183+
if args.shared_libs:
1184+
build_type_arg += "--shared-libs "
1185+
11831186
if build_opts.free_up_disk:
11841187
free_up_disk = "--free-up-disk "
11851188
if not build_opts.is_windows():

0 commit comments

Comments
 (0)